Skip to content

Conversation

@pcholakov
Copy link
Collaborator

No description provided.

@pcholakov pcholakov requested a review from Copilot June 23, 2025 20:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Restate constructs and end-to-end tests to target Restate Server v1.4.0, add support for inline image digests, introduce a separate NPM tools tag, and adjust test stack paths and rollback behavior.

  • Bump default Docker and NPM tags to 1.4, parse inline tags/digests, and introduce restateNpmTag
  • Update E2E test stack imports/paths, add NO_ROLLBACK support, and adjust stack naming
  • Refresh snapshots and update README with new flags

Reviewed Changes

Copilot reviewed 8 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
test/e2e/stacks/restate-cloud-lambda-stack.ts Fix import path to lib/restate-constructs
test/e2e/stacks/ec2-simple-stack.ts Update import path, dynamic stackName, add SSH rule, asset code
test/e2e/restate-cloud-lambda-test.e2e.ts Change cdkAppPath to include stacks/ subfolder
test/e2e/ec2-simple-test.e2e.ts Change cdkAppPath, dynamic stackName
test/e2e/cdk-util.ts Replace RETAIN_STACK with NO_ROLLBACK flag
test/e2e/README.md Document new NO_ROLLBACK env var
test/snapshots/restate-constructs...snap Add CDK metadata to snapshots
lib/restate-constructs/single-node-restate-deployment.ts Bump default tags, parse image digests, add restateNpmTag
Comments suppressed due to low confidence (1)

lib/restate-constructs/single-node-restate-deployment.ts:65

  • The comment states the default tag is latest, but the constant RESTATE_DOCKER_DEFAULT_TAG was updated to 1.4. Please update the doc comment to reflect the new default.
  /** Restate Docker image tag. Defaults to `latest`. */

@pcholakov pcholakov force-pushed the pavel/oxqtzzuwyrkt branch 3 times, most recently from 32e8212 to e4564e2 Compare June 23, 2025 21:18
@pcholakov pcholakov force-pushed the pavel/oxqtzzuwyrkt branch from e4564e2 to 75b8f92 Compare June 23, 2025 21:23
@pcholakov pcholakov merged commit 0545172 into main Jun 23, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2025
@pcholakov pcholakov deleted the pavel/oxqtzzuwyrkt branch September 16, 2025 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants