Upgrade commonmark to avoid minor vulnerability #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old version, 0.27.0, has a vulnerability as described here: commonmark/commonmark.js#172
Author
|
Edit: done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commonmark0.27.0 has a denial-of-service vulnerability in the form of some inefficient parsing that takes quadratic time, as documented here: commonmark/commonmark.js#172This was fixed in
commonmark0.29.1, so this PR upgrades to that version. Running the tests locally they pass without further changes.At the moment, this PR should be considered a work in progress as it has an installation warning due to the new version of
commonmarknot matching thepeerDependenciesspec ofcommonmark-react-renderer. I have opened a PR in that project as well that should fix that issue, and this PR is dependent on that one: rexxars/commonmark-react-renderer#42 .