-
Notifications
You must be signed in to change notification settings - Fork 9
Add KDFTests #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KDFTests #78
Conversation
|
Despite well done and readable, the number of reflection is pretty big here. Similar approaches have already multiplied few times, and I think we should incorporate logic to go jdk by jdk. This project do not have binary releases, so you clone, build and try/test by same jdk. For jtreg-like approach, the jdk.version.major would be enough (although the one big test running all will need sme tuning). The make file can have detection too. Qurestion is whether to take this PR as oportunity to move in this direction, or merge, and work on removal of reflection as another step. WDYT? |
Slilghtly less the I thought. |
|
@judovana there are 2 test classes done completely in reflection that it Unfortunately avoiding reflection is not so easy as it may seem here. AFAIK list test of sources cannot be conditional based on jdk, so we would need to duplicate top level @test with all it's dependencies for each jdk which introduced new APIs... Which is not much better. :( Also as I have discovered, there is another fun part and that is dealing with preview features (btw. KDFTests are preview in jdk24). That needs additional compiler and runtime switches (not needed, when reflection is used). |
|
And in makefile I would need to deal with these problems too... :( |
I know that in makefile it would need much more care:( be sure I keep t in mind!-) However, manual listing of classes as is often much more easier then in other build tools. The other concerns you highlighted are already leading to some configure like |
|
The |
|
Maybe the jtregs conditionions (aka requires.extraPropDefns = VarDeps.java\n requires.properties = ...) may be used for jtreg parts, but that would complicate makefiles. However.. makefile an use the requires.extraPropDefns cass to get the same info... |
|
They would need to be excluded from compilation. We would still need add additional dummy files with different '@test' configurations for top level target... :( Unfortunately nor reflection in top level class nor |
|
Ok, lets merge thsi now. But I will look deeper into the reflection removal. |
|
Btw, we will probably also have opposite problem, where some APIs will only work on older JDKs. As our tests use some APIs deprecated for removal. See: #79 |
|
Yup. Sure thing... #80 filled. |
This adds support for testing of KDF API. (see JDK-8331008.
Fixes: #72
Currently reflection has to be, so that tests support all jdks... :(
(I have included comment with original code, without reflection)