Strong APA v1.3 #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedare
reviewed
Aug 26, 2020
| * @param thread Thread correspoding to the @node that asks for help. | ||
| * @param node node associated with @thread | ||
| */ | ||
| * @param scheduler The scheduler control instance. |
| * Finds and returns the highest ready node present by accessing the | ||
| * _Strong_APA_Context->CPU with front and rear values. | ||
| */ | ||
|
|
| first_task = true; | ||
|
|
||
|
|
||
| //Assert rear < sizeof(Context->CPU) |
|
|
||
|
|
||
| //Assert rear < sizeof(Context->CPU) | ||
| _Assert( rear < CONFIGURE_MAXIMUM_PROCESSOR ); |
| /* | ||
| * Highest ready is not just directly reachable from the victim cpu | ||
| * So there is need of task shifting . |
There was a problem hiding this comment.
"need for" and remove space before period.
| next_thread = curr_strong_node->invoker->heir; | ||
| next_node = _Thread_Scheduler_get_home_node( next_thread ); | ||
|
|
||
| while( curr_node != lowest_reachable ) { |
| //Add it to All_nodes chain since it is now either scheduled or just ready. | ||
|
|
||
| //Add it to Ready chain since it is now either scheduled or just ready. | ||
| _Scheduler_strong_APA_Insert_ready(context,node,insert_priority); |
| //Add it to All_nodes chain since it is now either scheduled or just ready. | ||
|
|
||
| //Add it to Ready chain since it is now either scheduled or just ready. |
|
|
||
| //Checks if the thread_CPU is in the affinity set of the node | ||
| if ( _Processor_mask_Is_set( &strong_node->Affinity, cpu_index) ) { | ||
| if ( _Processor_mask_Is_set( &strong_node->Affinity, cpu_index) ) { |
| _Scheduler_strong_APA_Has_ready, | ||
| _Scheduler_strong_APA_Enqueue_scheduled, | ||
| _Scheduler_strong_APA_Register_idle | ||
| _Scheduler_SMP_Do_nothing_register_idle |
There was a problem hiding this comment.
since now you don't use _Scheduler_strong_APA_Register_idle you should delete its file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.