Skip to content

implement is_isogram #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinsparr wants to merge 2 commits into
base: master
Choose a base branch
from
Open

implement is_isogram #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac96a24
implement is_isogram
martinsparr Oct 31, 2022
16bad9a
small change
martinsparr Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/isogram.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,25 @@
#include <string.h>
#include <stdio.h>

char oldletter;
Copy link
Owner

@riederm riederm Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we move these into the method and have local variables instead of globals?

char newletter;
int count = 0;


bool is_isogram(const char phrase[]){

wihle(phrase[count] != '\0'){
Copy link
Owner

@riederm riederm Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type while

newletter = phrase[counter];

if (counter >= 1){
Copy link
Owner

@riederm riederm Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo counter

oldletter = phrase[counter -1];
if (newletter == oldletter){
printf("It`s not an isisogram!!");
Copy link
Owner

@riederm riederm Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove printfs

return false;
}
}
count++;
}
printf("It`s an isisogram!!");
return true;
}