Skip to content

Invalid DX resource flags cause rive renderer initialization to fail #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gustavo-lighttwist wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Invalid DX resource flags cause rive renderer initialization to fail #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions renderer/include/rive/renderer/d3d12/d3d12_utils.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,7 +449,7 @@ class D3D12ResourceManager : public GPUResourceManager
rcp<D3D12Buffer> makeUploadBuffer(
UINT size,
D3D12_RESOURCE_FLAGS bindFlags = D3D12_RESOURCE_FLAG_NONE,
D3D12_RESOURCE_STATES initialState = D3D12_RESOURCE_STATE_COPY_SOURCE,
D3D12_RESOURCE_STATES initialState = D3D12_RESOURCE_STATE_GENERIC_READ,
D3D12_HEAP_FLAGS heapFlags = D3D12_HEAP_FLAG_NONE);

rcp<D3D12VolatileBuffer> makeVolatileBuffer(
Expand All @@ -465,7 +465,7 @@ class D3D12ResourceManager : public GPUResourceManager
rcp<D3D12Buffer> uploadBuffer =
makeUploadBuffer(sizeInBytes,
D3D12_RESOURCE_FLAG_NONE,
D3D12_RESOURCE_STATE_COPY_SOURCE);
D3D12_RESOURCE_STATE_GENERIC_READ);
rcp<D3D12Buffer> constBuffer = makeBuffer(sizeInBytes,
D3D12_RESOURCE_FLAG_NONE,
D3D12_RESOURCE_STATE_COMMON);
Expand Down
2 changes: 1 addition & 1 deletion renderer/src/d3d12/d3d12_utils.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,7 +379,7 @@ void D3D12VolatileBuffer::resizeBuffers(UINT newSize)
{
m_uploadBuffer = d3d()->makeUploadBuffer(newSize,
D3D12_RESOURCE_FLAG_NONE,
D3D12_RESOURCE_STATE_COPY_SOURCE);
D3D12_RESOURCE_STATE_GENERIC_READ);
m_gpuBuffer = d3d()->makeBuffer(newSize,
m_bindFlags,
D3D12_RESOURCE_STATE_COMMON,
Expand Down