Fix ERB issues surfaced by Herb #5497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of working to integrate [Herb](https://github.com/marcoroth/herb), I ran into some issues with graphql-ruby when enabling Herb for all ERB and HTML in our application. This PR fixes the majority of the issues raised by the linter. I've filed a [bug](marcoroth/herb#1060) for a case that I think shouldn't be raised. cc @marcoroth
Owner
|
Awesome, thank you! If you'd like me to keep up compliance here, I'd also welcome a PR (or some advice about) integrating Herb into the gem's CI. |
Contributor
Author
|
@rmosolgo you're welcome! I'll have a PR to use Herb in CI for you once it's a bit more mature ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of working to integrate Herb, I ran into some issues with graphql-ruby when enabling Herb for all ERB and HTML in our application.
This PR fixes the majority of the issues raised by the linter.
I've filed a bug for a case that I think shouldn't be raised.
cc @marcoroth