Skip to content

Conversation

@roanutil
Copy link
Owner

@roanutil roanutil commented May 2, 2025

I think we are using subscription types in a safe way but they are not easily made Sendable. Let me know if you see anything that could be problematic with @unchecked Sendable.

@roanutil roanutil requested a review from r-jarvis May 2, 2025 21:14
@roanutil roanutil changed the title Add Sendable Conformances Add Sendable Conformances (Depends on #35) May 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2025

Codecov Report

Attention: Patch coverage is 49.27536% with 35 lines in your changes missing coverage. Please review.

Project coverage is 82.33%. Comparing base (dc094d0) to head (f479476).
Report is 17 commits behind head on 3.0-preview.

Files with missing lines Patch % Lines
Sources/CoreDataRepository/CoreDataError.swift 0.00% 33 Missing ⚠️
...es/Internal/ModelsWithIntId/ManagedModel_Int.swift 0.00% 1 Missing ⚠️
...rces/Internal/NSManagedObjectModel+Constants.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           3.0-preview      #36      +/-   ##
===============================================
- Coverage        84.26%   82.33%   -1.93%     
===============================================
  Files               35       65      +30     
  Lines             2936     7315    +4379     
===============================================
+ Hits              2474     6023    +3549     
- Misses             462     1292     +830     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@r-jarvis r-jarvis merged commit 4c001f3 into 3.0-preview May 8, 2025
2 checks passed
@roanutil roanutil deleted the feature/sendable branch May 8, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants