Skip to content

Conversation

@roanutil
Copy link
Owner

Depends on #37

The main thing I'm not 100% happy with is that transactionAuthor on endpoints is ignored within a transaction. I don't see a reasonable way around it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 97.77542% with 63 lines in your changes missing coverage. Please review.

Project coverage is 86.57%. Comparing base (dc094d0) to head (ab6b1d9).
Report is 35 commits behind head on 3.0-preview.

Files with missing lines Patch % Lines
...ts/CoreDataRepositoryTests/Create_BatchTests.swift 93.81% 24 Missing ⚠️
Tests/CoreDataRepositoryTests/CreateTests.swift 91.02% 14 Missing ⚠️
Tests/CoreDataRepositoryTests/CustomTests.swift 93.45% 7 Missing ⚠️
...sts/CoreDataRepositoryTests/TransactionTests.swift 98.51% 6 Missing ⚠️
...ources/CoreDataRepository/CoreDataRepository.swift 91.48% 4 Missing ⚠️
Sources/CoreDataRepository/CoreDataError.swift 72.72% 3 Missing ⚠️
.../CoreDataRepository/CoreDataRepository+Fetch.swift 50.00% 2 Missing ⚠️
...DataRepository/CoreDataRepository+Read_Batch.swift 75.00% 2 Missing ⚠️
Tests/CoreDataRepositoryTests/AggregateTests.swift 99.81% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           3.0-preview      #38      +/-   ##
===============================================
+ Coverage        84.26%   86.57%   +2.31%     
===============================================
  Files               35       69      +34     
  Lines             2936     9627    +6691     
===============================================
+ Hits              2474     8335    +5861     
- Misses             462     1292     +830     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

roanutil added 2 commits June 24, 2025 12:22
…before exiting withTransaction

feature/transactions
@r-jarvis r-jarvis merged commit da539b7 into 3.0-preview Jun 30, 2025
2 checks passed
@roanutil roanutil deleted the feature/transactions branch June 30, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants