Skip to content

Fix name of IdentifiedUnmanagedModel.unmanagedIdExpression #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
r-jarvis merged 3 commits into from
Oct 10, 2025
Merged

Fix name of IdentifiedUnmanagedModel.unmanagedIdExpression #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cce4185
Fix name of IdentifiedUnmanagedModel.unmanagedIdExpression
roanutil Oct 9, 2025
c7b8e85
Run swiftformat
roanutil Oct 9, 2025
0eba960
Merge branch '3.0-preview' into feature/fix-misnamed-property
roanutil Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Sources/CoreDataRepository/IdentifiedUnmanagedModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import CoreData
public protocol IdentifiedUnmanagedModel: ReadableUnmanagedModel {
associatedtype UnmanagedId: Equatable
var unmanagedId: UnmanagedId { get }
static var managedIdExpression: NSExpression { get }
static var unmanagedIdExpression: NSExpression { get }
}

extension IdentifiedUnmanagedModel {
Expand All @@ -22,7 +22,7 @@ extension IdentifiedUnmanagedModel {
public static func readManaged(id: UnmanagedId, from context: NSManagedObjectContext) throws -> ManagedModel {
let request = Self.managedFetchRequest()
request.predicate = NSComparisonPredicate(
leftExpression: Self.managedIdExpression,
leftExpression: Self.unmanagedIdExpression,
rightExpression: NSExpression(forConstantValue: id),
modifier: .direct,
type: .equalTo
Expand Down
2 changes: 1 addition & 1 deletion Sources/Internal/ModelsWithIntId/IdentifiableModel_Int.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ extension IdentifiableModel_IntId: IdentifiedUnmanagedModel {
id
}

package nonisolated(unsafe) static let managedIdExpression = NSExpression(forKeyPath: \ManagedModel_IntId.id)
package nonisolated(unsafe) static let unmanagedIdExpression = NSExpression(forKeyPath: \ManagedModel_IntId.id)
}

extension IdentifiableModel_IntId: WritableUnmanagedModel {
Expand Down
2 changes: 1 addition & 1 deletion Sources/Internal/ModelsWithUuidId/IdentifiableModel_Uuid.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ extension IdentifiableModel_UuidId: IdentifiedUnmanagedModel {
id
}

package nonisolated(unsafe) static let managedIdExpression = NSExpression(forKeyPath: \ManagedModel_UuidId.id)
package nonisolated(unsafe) static let unmanagedIdExpression = NSExpression(forKeyPath: \ManagedModel_UuidId.id)
}

extension IdentifiableModel_UuidId: WritableUnmanagedModel {
Expand Down