Skip to content

Fix support for titles with symbols in them #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laverdet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix support for titles with symbols in them #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions jbripper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,20 @@ def printstr(str): # print without newline
sys.stdout.write(str)
sys.stdout.flush()

def shell(cmdline): # execute shell commands (unicode support)
call(cmdline, shell=True)

def rip_init(session, track):
global pipe, ripping, pcmfile, rawpcm
num_track = "%02d" % (track.index(),)
mp3file = track.name()+".mp3"
pcmfile = track.name()+".pcm"
directory = os.getcwd() + "/" + track.artists()[0].name() + "/" + track.album().name() + "/"
file_prefix = os.getcwd() + "/" + track.artists()[0].name() + "/" + track.album().name() + "/" + track.name()
file_prefix = file_prefix.replace('*', '_')
mp3file = file_prefix+".mp3"
directory = os.path.dirname(file_prefix)
if not os.path.exists(directory):
os.makedirs(directory)
printstr("ripping " + mp3file + " ...")
p = Popen("lame --silent -V0 -h -r - \""+ directory + mp3file+"\"", stdin=PIPE, shell=True)
printstr("ripping " + file_prefix + ".mp3 ...")
p = Popen(["lame", "--silent", "-V0", "-h", "-r", "-", file_prefix + ".mp3"], stdin=PIPE)
pipe = p.stdin
if rawpcm:
pcmfile = open(directory + pcmfile, 'w')
pcmfile = open(file_prefix + ".pcm", 'w')
ripping = True


Expand Down Expand Up @@ -73,19 +71,19 @@ def rip_id3(session, track): # write ID3 data
fh_cover.close()

# write id3 data
cmd = "eyeD3" + \
" --add-image cover.jpg:FRONT_COVER" + \
" -t \"" + title + "\"" + \
" -a \"" + artist + "\"" + \
" -A \"" + album + "\"" + \
" -n " + str(num_track) + \
" -Y " + str(year) + \
" -Q " + \
" \"" + directory + mp3file + "\""
shell(cmd)
call(["eyeD3",
"--add-image", "cover.jpg:FRONT_COVER",
"-t", title,
"-a", artist,
"-A", album,
"-n", str(num_track),
"-Y", str(year),
"-Q",
(directory + mp3file).replace('*', '_')
])

# delete cover
shell("rm -f cover.jpg")
call(["rm", "-f", "cover.jpg"])

class RipperThread(threading.Thread):
def __init__(self, ripper):
Expand Down