Fix parsing 6S output with values prinated with astersisk #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it won't interfere with outputs printed with asterisks only (it happens when 6S is not able to print numbers according to the provided format).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, 6S prints values as a sequence of asterisks instead of proper number. It happens when 6S/Fortran is not able to print numbers according to the provided format. However, it interferes with parsing output in Py6S and leads to an error.
This change should fix the issue by removing asterisks belonging to tables (printed by 6S) only. Values printed with asterisks are returned as NaNs in Py6S.