Skip to content

Loading Spinner #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
radufarcas10 wants to merge 6 commits into
base: integration
Choose a base branch
from
Open

Loading Spinner #11

radufarcas10 wants to merge 6 commits into from

Conversation

@radufarcas10
Copy link
Collaborator

@radufarcas10 radufarcas10 commented Oct 4, 2017

No description provided.

@radufarcas10 radufarcas10 changed the title Loading bar Loading Spinner Oct 4, 2017
@radufarcas10
Copy link
Collaborator Author

radufarcas10 commented Oct 4, 2017

Please remove files added by WebStorm (.idea) and add .idea/ to .gitignore

radufarcas10
radufarcas10 commented Oct 4, 2017
View reviewed changes
root/src/style/components/example.scss Outdated
transform: rotate(360deg);
}
}
.circularProgress__overlay{
Copy link
Collaborator Author

@radufarcas10 radufarcas10 Oct 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's stick to a naming convention for class names. So this should be circular-progress-overlay instead of circularProgress__overlay. Find a better and more suggestive name for the class name

root/src/style/components/example.scss Outdated
$backgroundColor:#fffdf8;


@mixin circle($size){
Copy link
Collaborator Author

@radufarcas10 radufarcas10 Oct 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this mixin to mixins folder or file

@radufarcas10
Copy link
Collaborator Author

radufarcas10 commented Oct 4, 2017

Also change the file name from example.scss. The file should be named after the component itself

@radufarcas10
Copy link
Collaborator Author

radufarcas10 commented Oct 5, 2017

please add .idea/ to .gitignore file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ionuttoader ionuttoader Awaiting requested review from ionuttoader

@dianapintea dianapintea Awaiting requested review from dianapintea

@robipop22 robipop22 Awaiting requested review from robipop22

@popvasilevlad popvasilevlad Awaiting requested review from popvasilevlad

@ileaugustin ileaugustin Awaiting requested review from ileaugustin

@bogdan-budnar bogdan-budnar Awaiting requested review from bogdan-budnar

Assignees

@hollowjokken hollowjokken

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radufarcas10 @hollowjokken