Annotate and document kerning.py.
#813
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@knutnergaard was I off base with those comments? |
Contributor
Author
benkiel
requested changes
Jun 16, 2025
| [-20, -15, 5, 3.5] | ||
| """ | ||
| return super(BaseKerning, self).values() | ||
| super(BaseKerning, self).update(otherKerning) |
Contributor
Author
There was a problem hiding this comment.
No. Is it really supposed to? The BaseDict method doesn't, so returning here will result in a mypy error.
Member
There was a problem hiding this comment.
That makes sense, ok with this change
Member
There was a problem hiding this comment.
Also, I think the diff was confusing me here, update vs values
Member
|
@knutnergaard sorry, I answered my comment questions, but then had two more. |
benkiel
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.