Skip to content

Conversation

@LettError
Copy link
Member

For your consideration. This addresses issue #850.
Summary: during fromMathGlyph, a guideline can have a color that can be a defcon color object rather than a tuple. This adds some resilience without creating too many expectations or dependency on defcon.

This is a small but annoying issue that in effect requires all guidelines to be removed from source glyphs before starting calculations.

and if it is not a tuple, try if it is a defcon color object
and if it is not a defcon object, discard the color but please don't crash.
@codecov
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.25%. Comparing base (29dabb3) to head (704c188).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
Lib/fontParts/base/glyph.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #851      +/-   ##
==========================================
- Coverage   78.31%   78.25%   -0.07%     
==========================================
  Files          41       41              
  Lines        6107     6112       +5     
  Branches      916      917       +1     
==========================================
  Hits         4783     4783              
- Misses       1117     1122       +5     
  Partials      207      207              
Files with missing lines Coverage Δ
Lib/fontParts/base/glyph.py 76.89% <0.00%> (-0.40%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@typesupply typesupply self-requested a review August 14, 2025 02:12
@typesupply typesupply merged commit a6934ad into master Aug 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants