refactor: use types to enforce valid state transitions #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockstar
force-pushed
the
refactor/complete-type-safety
branch
from
b389117 to
3c0647e
Compare
Owner
Author
|
Gonna leave this one open for a bit and stew on it. I like the type safety of it, and the immutability of the lock, but it's a significant change. |
This patch creates a new API for `Pidlock`, using rust's type system to ensure invalid state transitions are a compile time error, rather than a runtime error. `Pidlock` is now `Pidlock<T>`, where `T` is a state, `New`, `Acquired`, or `Released`. Only `New` can be created by a user, and the specific apis allow us to transition from valid state to valid state. For more information, see the included documentation.
rockstar
force-pushed
the
refactor/complete-type-safety
branch
from
3c0647e to
ac035c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch creates a new API for
Pidlock, using rust's type system to ensure invalid state transitions are a compile time error, rather than a runtime error.Pidlockis nowPidlock<T>, whereTis a state,New,Acquired, orReleased. OnlyNewcan be created by a user, and the specific apis allow us to transition from valid state to valid state. For more information, see the included documentation.