refactor: use windows instead of windows-sys #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockstar
force-pushed
the
refactor/windows-not-windows-sys
branch
3 times, most recently
from
bf9d032 to
9887797
Compare
This patch replaces the use of `windows-sys` with `windows`, providing a safe(r) API wrapper around the `windows-sys` crate. Unfortunately, it doesn't entirely remove the `unsafe` windows code, because a fully safe API isn't provided. This change focuses on limiting and calling out the unsafe bits.
rockstar
force-pushed
the
refactor/windows-not-windows-sys
branch
from
9887797 to
fbf144e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces the use of
windows-syswithwindows, providing a safe API wrapper around thewindows-syscrate. This removes the unsafe code related to windows.