-
Notifications
You must be signed in to change notification settings - Fork 5
chore: release v1.9.0 #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Features: - Hierarchical skill tree with 12 categories (skillkit tree) - LLM-based reasoning engine for skill discovery - Explainable recommendations (--explain, --reasoning flags) - Connector placeholders for tool-agnostic skills (~~CRM, ~~chat, etc.) - Execution flow tracking with metrics - Standalone vs Enhanced mode detection CLI: - New `tree` command for taxonomy navigation - Enhanced `recommend` with explanation support - Fixed --skill alias and agent detection Documentation: - Added tree.mdx for Skill Tree documentation - Updated recommendations.mdx with reasoning features - Updated TUI docs with tree view mode - Updated README with new features - Updated website Features and Commands
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis release introduces skill tree navigation and explainable recommendations to SkillKit. Version bumped to 1.9.0 across the monorepo. Documentation expanded with tree browsing, reasoning-based discovery workflows, and TUI tree view interactions. UI components updated to highlight new tree feature. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Devin Review found 1 potential issue.
🟡 1 issue in files not directly in the diff
🟡 Tilde path expansion uses process.env.HOME instead of os.homedir() (packages/core/src/execution/mode.ts:100)
The PR description claims "Fixed tilde path expansion (use os.homedir())" but the code in detectMcpServers() still uses process.env.HOME for tilde expansion.
Click to expand
Issue
At line 100, the code expands tilde paths using:
const fullPath = configPath.startsWith('~')
? configPath.replace('~', process.env.HOME || '')
: configPath;On Windows, process.env.HOME is typically undefined, causing the tilde to be replaced with an empty string. This results in invalid paths like /.mcp.json instead of C:\Users\username\.mcp.json.
Expected Behavior
The code should use homedir() (which is already imported at line 5) for cross-platform compatibility:
const fullPath = configPath.startsWith('~')
? configPath.replace('~', homedir())
: configPath;Impact
Windows users passing custom MCP config paths with tilde (e.g., ~/.mcp.json) will have those paths incorrectly resolved, causing MCP server detection to silently fail. The default paths at lines 40-44 correctly use join(homedir(), ...) so the impact is limited to custom configurations.
Recommendation: Replace process.env.HOME || '' with homedir() to ensure cross-platform compatibility, matching the approach used for DEFAULT_MCP_CONFIG_PATHS at lines 40-41.
View issue and 5 additional flags in Devin Review.
Release v1.9.0
Features
Hierarchical Skill Tree - Browse 15K+ skills in a navigable taxonomy with 12 categories
skillkit tree- Full tree viewskillkit tree Frontend- Category navigationskillkit tree --stats- Statisticsv)LLM-Based Reasoning Engine - Smart skill discovery using reasoning over taxonomy
skillkit recommend --reasoning- LLM-based searchskillkit recommend --explain- See WHY skills matchConnector Placeholders - Tool-agnostic skill authoring
Execution Flow Tracking - Step-by-step execution with metrics
Standalone vs Enhanced Mode - Automatic capability detection
Bug Fixes
--skillalias and agent detectionDocumentation
tree.mdxdocumentationSummary by CodeRabbit