Intersection Type #1603
Draft
Intersection Type #1603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n and using union type in BRS mode
markwpearce
commented
Jan 5, 2026
| } | ||
| let rightParen = this.advance(); | ||
|
|
||
| let rightParen = this.consume( |
Collaborator
Author
There was a problem hiding this comment.
This has been a bug a for a while? If the token was not ) it would just assume it was. :)
markwpearce
commented
Jan 5, 2026
| expressionsWithOperator.push({ expression: expr }); | ||
|
|
||
| // handle expressions with order of operations - first "and", then "or" | ||
| const combineExpressions = (opToken: TokenKind) => { |
Collaborator
Author
There was a problem hiding this comment.
Potentially there is a better way of doing this...
This algorithm just gets a list of <type> <operator?>, and then first loops through it to combine all ands into binary expressions, then again to combine all ors
markwpearce
commented
Jan 5, 2026
| if (this.match(TokenKind.LeftCurlyBrace)) { | ||
| expr = this.inlineInterface(); | ||
| } else if (this.match(TokenKind.LeftParen)) { | ||
| let left = this.previous(); |
Collaborator
Author
There was a problem hiding this comment.
This type expression is a GroupingExpxression, eg. (integer or float)
markwpearce
commented
Jan 5, 2026
| getSymbolType: (innerName: string, innerOptions: GetTypeOptions) => { | ||
| const referenceTypeInnerMemberTypes = this.getMemberTypeFromInnerTypes(name, options); | ||
| if (!innerTypesMemberTypes || innerTypesMemberTypes.includes(undefined)) { | ||
| if (!referenceTypeInnerMemberTypes || referenceTypeInnerMemberTypes.includes(undefined)) { |
Collaborator
Author
There was a problem hiding this comment.
Fixes typo in code.. fixed an issue, but I can't remember exactly what ...
markwpearce
commented
Jan 5, 2026
| } | ||
| return this.isTypeCompatible(targetType) && targetType.isTypeCompatible(this); | ||
|
|
||
| if (this.types.length !== targetType.types.length) { |
Collaborator
Author
There was a problem hiding this comment.
More exact check for wquality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
IntersectionTypemodelled after TypeScript's intersection typesIntersectionType<type> and <type>(type1 or type2) and (type3 or type4))type foo = myType1 or myType2 and myType3 or myType4=>myType1 or (myType2 and myType3) or myType4type MyKlassAA = MyKlass and roAssociativeArrayworks properly