-
-
Notifications
You must be signed in to change notification settings - Fork 12
788-feat: Add filter for merch #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
π Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
π Files selected for processing (2)
src/widgets/merch-catalog/ui/merch-filter/merch-tags-dropdown/merch-tags-dropdown.tsx(1 hunks)src/widgets/merch-catalog/ui/no-merch/no-merch.tsx(1 hunks)
π§° Additional context used
π§ Learnings (1)
π Learning: 2024-12-14T11:15:51.682Z
Learnt from: Quiddlee
PR: rolling-scopes/site#659
File: src/widgets/school-menu/ui/school-item/school-item.tsx:0-0
Timestamp: 2024-12-14T11:15:51.682Z
Learning: When an image is purely decorative, adding `aria-hidden="true"` to the `Image` component is acceptable for accessibility instead of providing an alt text.
Applied to files:
src/widgets/merch-catalog/ui/merch-filter/merch-tags-dropdown/merch-tags-dropdown.tsx
𧬠Code graph analysis (2)
src/widgets/merch-catalog/ui/merch-filter/merch-tags-dropdown/merch-tags-dropdown.tsx (1)
src/shared/ui/subtitle/subtitle.tsx (1)
Subtitle(36-59)
src/widgets/merch-catalog/ui/no-merch/no-merch.tsx (4)
src/widgets/merch-catalog/index.ts (1)
NoMerch(2-2)src/shared/ui/paragraph/paragraph.tsx (1)
Paragraph(24-36)src/shared/constants.ts (1)
ROUTES(96-115)src/widgets/merch-catalog/ui/merch-catalog.tsx (1)
products(13-34)
π Additional comments (2)
src/widgets/merch-catalog/ui/no-merch/no-merch.tsx (2)
1-11: Verify if 'use client' directive is needed.A past reviewer suggested adding the 'use client' directive at the top of this file. While this component has no client-side interactivity (hooks or handlers), verify whether the parent usage context requires it to be a Client Component.
Based on past review comments.
29-43: LGTM!The conditional rendering logic is clean and the text content appropriately reflects the filtered/unfiltered states. Good use of LinkCustom for navigation.
src/widgets/merch-catalog/ui/merch-filter/merch-tags-dropdown/merch-tags-dropdown.tsx
Show resolved
Hide resolved
β¦ter readability
What type of PR is this? (select all that apply)
Description
Add filter for merch page for desktop and mobile view
Add tests for filter component
Related Tickets & Documents
Screenshots, Recordings
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?
Summary by CodeRabbit
New Features
Style
Tests
Chores