forked from MagicStack/asyncpg
-
Notifications
You must be signed in to change notification settings - Fork 3
Fixed tests so they pass on windows. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JesseDeLoore
wants to merge
43
commits into
ronyb29:target_session_attr
Choose a base branch
from
JesseDeLoore:target_session_attr
base: target_session_attr
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fixed tests so they pass on windows. #1
JesseDeLoore
wants to merge
43
commits into
ronyb29:target_session_attr
from
JesseDeLoore:target_session_attr
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virtual environment directories are often named `.venv` by convention.
This moves the project to a more modern version of flake8 (and its dependencies). No new lint issues were identified by this upgrade.
This demonstrates a dot-notation implementation as suggested by this FAQ item.
We support Record subclasses, so include the exact type name (rather than just 'Record') in the repr() string.
Support Python 3.11 and PostgreSQL 15. This release also drops support for Python 3.6. Changes ======= * Add arm64 mac and linux wheels (by @ddelange in 7bd6c49 for MagicStack#954) * Add Python 3.11 to the test matrix (by @elprans in 5f908e6 for MagicStack#948) * Exclude .venv from flake8 (MagicStack#958) (by @jparise in 40b16ea for MagicStack#958) * Upgrade to flake8 5.0.4 (from 3.9.2) (MagicStack#961) (by @jparise in 0e73fec for MagicStack#961) * Show an example of a custom Record class (MagicStack#960) (by @jparise in 84c99bf for MagicStack#960) * Use the exact type name in Record.__repr__ (MagicStack#959) (by @jparise in eccdf61 for MagicStack#959) * Drop Python 3.6 support (MagicStack#940) (by @bryanforbes in bb0cb39 for MagicStack#940) * Test on Python 3.11 and PostgreSQL 15, fix workflow deprecations (MagicStack#968) (by @elprans in eab7fdf for MagicStack#968)
Avoids a warning
This supports a case where we prepare an unnamed statement to inspect the return types. The statement should not be cleaned up afterwards because it is automatically cleaned up by Postgres
Are the hosts unique for the replica clusters ? I find it hard to tell, but at least on Windows all clusters are on localhost, so the test was not actually verifying the code.
… into target_session_attr
Fix for jq skipping first line `input` Outputs one new input. `inputs` Outputs all remaining inputs, one by one. pypa/cibuildwheel#1261 (reply in thread)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are the hosts unique for the replica clusters ? I find it hard to tell, but at least on Windows all clusters are on localhost, so the test was not actually verifying the code.