Upgrade golangci-lint and config, address findings

.github/workflows/test.yml

@@ -38,7 +38,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.52.2
+          version: v1.55.2
       - name: go mod tidy
         run: go mod tidy
       - name: check for any changes

.golangci.yaml

@@ -9,9 +9,18 @@ linters-settings:
     disable:
       - fieldalignment
   depguard:
-    list-type: blacklist
-    include-go-root: true
-    include-go-std-lib: true
+    rules:
+      main:
+        allow:
+          - $gostd
+          - github.com/denisenkom/go-mssqldb
+          - github.com/go-sql-driver/mysql
+          - github.com/go-gorp/gorp/v3
+          - github.com/lib/pq
+          - github.com/mattn/go-sqlite3
+          - github.com/mitchellh/cli
+          - github.com/olekukonko/tablewriter
+          - github.com/rubenv/sql-migrate
   exhaustive:
     default-signifies-exhaustive: true
   nolintlint:

init_test.go

@@ -3,6 +3,7 @@ package migrate
 import (
 	"testing"
 
+	//revive:disable-next-line:dot-imports
 	. "gopkg.in/check.v1"
 )
 

migrate_test.go

@@ -8,8 +8,10 @@ import (
 	"time"
 
 	"github.com/go-gorp/gorp/v3"
-	_ "github.com/mattn/go-sqlite3"
+	//revive:disable-next-line:dot-imports
 	. "gopkg.in/check.v1"
+
+	_ "github.com/mattn/go-sqlite3"
 )
 
 var sqliteMigrations = []*Migration{

sort_test.go

@@ -3,6 +3,7 @@ package migrate
 import (
 	"sort"
 
+	//revive:disable-next-line:dot-imports
 	. "gopkg.in/check.v1"
 )
 

sql-migrate/config.go

@@ -5,7 +5,6 @@ import (
 	"errors"
 	"flag"
 	"fmt"
-	"io/ioutil"
 	"os"
 	"runtime/debug"
 
@@ -45,7 +44,7 @@ type Environment struct {
 }
 
 func ReadConfig() (map[string]*Environment, error) {
-	file, err := ioutil.ReadFile(ConfigFile)
+	file, err := os.ReadFile(ConfigFile)
 	if err != nil {
 		return nil, err
 	}

sqlparse/sqlparse_test.go

@@ -4,6 +4,7 @@ import (
 	"strings"
 	"testing"
 
+	//revive:disable-next-line:dot-imports
 	. "gopkg.in/check.v1"
 )
 

toapply_test.go

@@ -3,6 +3,7 @@ package migrate
 import (
 	"sort"
 
+	//revive:disable-next-line:dot-imports
 	. "gopkg.in/check.v1"
 )