Add checked:bg-primary to combobox_toggle_all_checkbox #327
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pierry01
commented
Dec 9, 2025
Contributor
Author
There was a problem hiding this comment.
it's basically equal to combobox_checkbox
djalmaaraujo
requested changes
Dec 10, 2025
Contributor
djalmaaraujo
left a comment
djalmaaraujo
left a comment
There was a problem hiding this comment.
@pierry01 Can you update the pull request description with a proper before/after? Also, inform the purpose of this change? The screenshots failed to load. Thank you!
There was a problem hiding this comment.
Pull request overview
This PR adds checked state styling to the combobox toggle all checkbox component to ensure visual consistency when the checkbox is selected. The addition of checked:bg-primary and checked:text-primary-foreground classes aligns this component with other checkbox components in the codebase.
Key Changes:
- Added
checked:bg-primary checked:text-primary-foregroundclasses to provide proper styling for the checked state - Reordered CSS classes to group related styling concerns together (disabled, checked, aria-disabled, focus-visible)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE
AFTER