Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.
How to reproduce the bug:
the problem:
https://github.com/run-llama/llama_index/pull/20362/files#diff-c079fb67256ff4dae95c19afb0be6dc4b93c1f167bd82bf144c97b942cf2a9a7L200 It was adding a new signature (None) to all deltas. This would make the signatures list mismatch the actual content list, as for text, we count 1 sig for 1 text block (fully merged)
Accordingly to https://ai.google.dev/gemini-api/docs/thought-signatures#non-function-call other parts could also have thought signatures like text.
and here
We skip empty text blocks. So if a signature come in a empty text block we will skip it and it could reduce llm performance. The problem of checking for
if part.text is not Noneis that after a tool call, the llm will send an empty text by some reason and if its not skipped, it breaks the streaming silently. So I decided to keep the original behavior and skip empty (part.text being "") instead of checking forif is None