-
Notifications
You must be signed in to change notification settings - Fork 165
RUN-4060: Document Single-Screen Inline Runner Editing Feature #1754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUN-4060: Document Single-Screen Inline Runner Editing Feature #1754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| ### When Regenerate is Available | ||
|
|
||
| The **Regenerate Credentials** button visibility depends on Runner type and replica configuration: | ||
|
|
||
| **View Mode Requirement:** | ||
|
|
||
| - The **Regenerate Credentials** button is only visible in view mode (not shown during edit mode to maintain focus on basic information editing) | ||
|
|
||
| **When Replicas Feature is Enabled:** | ||
|
|
||
| - **Ephemeral Runners**: Can regenerate credentials (designed for dynamic environments) | ||
| - **Manual Runners**: Cannot regenerate credentials (use "Add Replica" workflow instead) | ||
|
|
||
| **When Replicas Feature is Disabled (Legacy Mode):** | ||
|
|
||
| - All Runner types can regenerate credentials for backward compatibility | ||
|
|
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The heading "When Regenerate is Available" introduces conditions but the formatting could be improved for clarity. Consider restructuring this section to use a clearer heading hierarchy. The sub-sections "View Mode Requirement", "When Replicas Feature is Enabled", and "When Replicas Feature is Disabled (Legacy Mode)" appear to be at the same level but are formatted with bold text instead of using proper heading levels (####). This creates inconsistent documentation structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
| **Note**: The **Node Dispatch** tab settings are managed and saved independently from the basic Runner information. To edit them, view a Runner (not in edit mode), open the **Node Dispatch** tab, adjust the settings, and use the tab's save action to persist those changes without affecting the other Runner fields. | ||
|
|
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Note section contains an overly long sentence that is difficult to parse. Consider breaking this into multiple sentences or a bulleted list to improve readability. The sentence structure "To edit them, view a Runner (not in edit mode), open the Node Dispatch tab, adjust the settings, and use the tab's save action to persist those changes without affecting the other Runner fields" could be simplified with clearer step-by-step formatting or broken into shorter, more digestible sentences.
| **Note**: The **Node Dispatch** tab settings are managed and saved independently from the basic Runner information. To edit them, view a Runner (not in edit mode), open the **Node Dispatch** tab, adjust the settings, and use the tab's save action to persist those changes without affecting the other Runner fields. | |
| **Note**: The **Node Dispatch** tab settings are managed and saved independently from the basic Runner information. | |
| To edit these settings: | |
| 1. View the Runner detail page in **View Mode** (not Edit Mode) | |
| 2. Open the **Node Dispatch** tab | |
| 3. Adjust the settings as needed | |
| 4. Use the **Node Dispatch** tab's save action to persist those changes without affecting the other Runner fields |
9b6ea3b
into
update-pr-feed-rba-5.19-RBA-20260107-18ac2eb-9f53a6c
No description provided.