Skip to content

Conversation

@jayas006
Copy link
Contributor

@jayas006 jayas006 commented Jan 8, 2026

No description provided.

@jayas006 jayas006 added this to the 5.19.0 milestone Jan 8, 2026
@jayas006 jayas006 marked this pull request as ready for review January 8, 2026 15:30
@jayas006 jayas006 requested review from a team and Copilot January 8, 2026 15:30

This comment was marked as outdated.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment on lines 296 to 312
### When Regenerate is Available

The **Regenerate Credentials** button visibility depends on Runner type and replica configuration:

**View Mode Requirement:**

- The **Regenerate Credentials** button is only visible in view mode (not shown during edit mode to maintain focus on basic information editing)

**When Replicas Feature is Enabled:**

- **Ephemeral Runners**: Can regenerate credentials (designed for dynamic environments)
- **Manual Runners**: Cannot regenerate credentials (use "Add Replica" workflow instead)

**When Replicas Feature is Disabled (Legacy Mode):**

- All Runner types can regenerate credentials for backward compatibility

Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading "When Regenerate is Available" introduces conditions but the formatting could be improved for clarity. Consider restructuring this section to use a clearer heading hierarchy. The sub-sections "View Mode Requirement", "When Replicas Feature is Enabled", and "When Replicas Feature is Disabled (Legacy Mode)" appear to be at the same level but are formatted with bold text instead of using proper heading levels (####). This creates inconsistent documentation structure.

Copilot generated this review using guidance from repository custom instructions.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot open a new pull request to apply changes based on this feedback

Comment on lines 290 to 291
**Note**: The **Node Dispatch** tab settings are managed and saved independently from the basic Runner information. To edit them, view a Runner (not in edit mode), open the **Node Dispatch** tab, adjust the settings, and use the tab's save action to persist those changes without affecting the other Runner fields.

Copy link

Copilot AI Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Note section contains an overly long sentence that is difficult to parse. Consider breaking this into multiple sentences or a bulleted list to improve readability. The sentence structure "To edit them, view a Runner (not in edit mode), open the Node Dispatch tab, adjust the settings, and use the tab's save action to persist those changes without affecting the other Runner fields" could be simplified with clearer step-by-step formatting or broken into shorter, more digestible sentences.

Suggested change
**Note**: The **Node Dispatch** tab settings are managed and saved independently from the basic Runner information. To edit them, view a Runner (not in edit mode), open the **Node Dispatch** tab, adjust the settings, and use the tab's save action to persist those changes without affecting the other Runner fields.
**Note**: The **Node Dispatch** tab settings are managed and saved independently from the basic Runner information.
To edit these settings:
1. View the Runner detail page in **View Mode** (not Edit Mode)
2. Open the **Node Dispatch** tab
3. Adjust the settings as needed
4. Use the **Node Dispatch** tab's save action to persist those changes without affecting the other Runner fields

Copilot uses AI. Check for mistakes.
@rundeck rundeck deleted a comment from Copilot AI Jan 8, 2026
@jayas006 jayas006 requested a review from fdevans January 8, 2026 18:22
@fdevans fdevans changed the base branch from 4.0.x to update-pr-feed-rba-5.19-RBA-20260107-18ac2eb-9f53a6c January 12, 2026 21:07
@fdevans fdevans merged commit 9b6ea3b into update-pr-feed-rba-5.19-RBA-20260107-18ac2eb-9f53a6c Jan 12, 2026
1 of 3 checks passed
@fdevans fdevans deleted the add-runner-management-docs-4.0.x branch January 12, 2026 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants