Draft: allow patching Git source dependencies with patch files #9001
Conversation
This is needed so that we have access to the target directory. In the special case where we have patch files, the checked out Git repo will be there instead of under $HOME/.cargo.
Patches need to be of `git format-patch` export. Filenames are relative
to workspace manifest. For example:
[patch.crates-io]
time = { git = "https://github.com/time-rs/time", tag = "0.1.41", patch-files = ["patches/0001-Hack-around-a-getting-precise-time-in-Windows.patch"]}
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Thank you for the work to make Cargo better! We unfortunately have a lot of things floating around in our issues, not all of witch are good ideas. We have not had time to document which we think are/not worth implementing. As mentioned (but not clearly) in the Contributor Guide here and here, we want to discuss ideas before work is put in on implementation and intend to tag Feature accepted when the conversation has concluded that it is good to go. I don't know if this functionality is something the Team wants in Cargo. I look forward to discussing the pros and cons. This message is just ment as a heads up that this PR may not get merge, with no intended criticism of you or your work. |
|
I would agree with @Eh2406 that this seems like a weighty enough feature that I don't think starting with merging or discussion on a PR is best. I think instead there should be a discussion about how this would work in Cargo and such, ideally through an RFC but not necessarily required. |
|
Ok, so maybe this wasn't discussed enough in the original issue #4648 - we can do it there. I'll write an RFC based on the discussion. |
|
☔ The latest upstream changes (presumably #9133) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Closing per the comments above about designing and implementing new features. Thanks! |
6 participants
First attempt at addressing #4648. This is a functioning demo (though sure there are some bugs).
This is currently lacking testing/documentation to get early feedback. It's also narrowed to Git sources only (i.e.
git = <url>),patch-filesspec on other sources are currently ignored.I'm posting this to understand whether I've came close to a good approach before investing more time to extend it, and to get some answers to questions that came up during the implementation -
SourceIdknow about the patches? Does the lockfile need to know?TomlDependency?target/, and what should we name this directory?gitcommand in order to apply the patches, or should we rely overpatchutil, or on some Rust crate that knows how to apply diffs independently?