Check for fully qualified paths in unnecessary_cast
#10971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @dswij (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
dswij
reviewed
Jun 27, 2023
Centri3
force-pushed
the
unnecessary_cast_fully_qual_fix
branch
from
7f396e6 to
33cd266
Compare
Contributor
|
☔ The latest upstream changes (presumably #11046) made this pull request unmergeable. Please resolve the merge conflicts. |
Centri3
force-pushed
the
unnecessary_cast_fully_qual_fix
branch
2 times, most recently
from
63d31dc to
e02f7cd
Compare
dswij
reviewed
Jul 20, 2023
Member
dswij
left a comment
dswij
left a comment
There was a problem hiding this comment.
Just a small comment, and I think it's good to merge afterward
Centri3
force-pushed
the
unnecessary_cast_fully_qual_fix
branch
from
e02f7cd to
c450e47
Compare
Centri3
force-pushed
the
unnecessary_cast_fully_qual_fix
branch
from
c450e47 to
15b68c2
Compare
Member
|
@bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
1 similar comment
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this doesn't pick up
::std::primitive::u32or the sort, now it doeschangelog: none