Stabilize atomic_try_updateand deprecate fetch_update starting 1.96.0
#148590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
5 tasks
Contributor
|
I would suggest splitting out the lint change into a separate PR. It would be useful even before stabilization, I don't think it requires its own FCP, and it'll make the API stabilization itself a bit easier to review. That's especially important since the simultaneous deprecation makes it a big and tricky diff by stabilization standards! |
GrigorenkoPV
force-pushed
the
atomic_try_update
branch
from
02e586c to
67b2e92
Compare
Contributor
Author
|
Good idea! Done: #148601 |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 8, 2025
…ng, r=Kivooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang#148590 Tracking issue for `update` and `try_update`: rust-lang#135894
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 8, 2025
…ng, r=Kivooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang#148590 Tracking issue for `update` and `try_update`: rust-lang#135894
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 9, 2025
…ng, r=Kivooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang#148590 Tracking issue for `update` and `try_update`: rust-lang#135894
rust-timer
added a commit
that referenced
this pull request
Nov 9, 2025
GrigorenkoPV
force-pushed
the
atomic_try_update
branch
from
67b2e92 to
7ffe34e
Compare
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 10, 2025
…ooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang/rust#148590 Tracking issue for `update` and `try_update`: rust-lang/rust#135894
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Nov 10, 2025
…ooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang/rust#148590 Tracking issue for `update` and `try_update`: rust-lang/rust#135894
makai410
pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
…ng, r=Kivooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang#148590 Tracking issue for `update` and `try_update`: rust-lang#135894
makai410
pushed a commit
to makai410/rustc_public
that referenced
this pull request
Nov 16, 2025
…ooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang/rust#148590 Tracking issue for `update` and `try_update`: rust-lang/rust#135894
Collaborator
|
☔ The latest upstream changes (presumably #149222) made this pull request unmergeable. Please resolve the merge conflicts. |
GrigorenkoPV
force-pushed
the
atomic_try_update
branch
from
7ffe34e to
9a0eb78
Compare
This comment has been minimized.
This comment has been minimized.
GrigorenkoPV
force-pushed
the
atomic_try_update
branch
from
9a0eb78 to
0733988
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
@rustbot label -S-waiting-on-FCP RIP |
and deprecate fetch_update starting 1.96.0
GrigorenkoPV
force-pushed
the
atomic_try_update
branch
from
0733988 to
65e453c
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Kobzol
pushed a commit
to Kobzol/rustc_codegen_cranelift
that referenced
this pull request
Dec 29, 2025
…ooeo `invalid_atomic_ordering`: also lint `update` & `try_update` Split from rust-lang/rust#148590 Tracking issue for `update` and `try_update`: rust-lang/rust#135894
Contributor
Author
|
r? t-libs |
Collaborator
|
Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''... Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip. |
apiraino
removed
the
T-compiler
Contributor
Author
|
@rustbot reroll Or what was that new command named |
jhpratt
removed
the
S-waiting-on-fcp
jhpratt
reviewed
Jan 25, 2026
| #[cfg_attr(miri, track_caller)] // even without panics, this helps for Miri backtraces | ||
| #[rustc_should_not_be_called_on_const_items] | ||
| #[deprecated( | ||
| since = "1.96.0", |
Member
There was a problem hiding this comment.
ping @Amanieu from #135894 (comment)
Point of clarification. Is it intended to deprecate this immediately with stabilization, have this set to a version further down the line, or simply TBD like the u8 module?
(also, does CURRENT_RUSTC_VERSION work here?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #135894
FCP completed: #135894 (comment)
1.96.0 was chosen because I don't think the remaining month until 1.93.0 becomes beta is enough for the FCP to finish and this to get merged, so 1.94.0 + a couple of versions of leeway: #135894 (comment)
Closes #135894