mir_build: Move and rename code for partitioning match candidates #149946
+362
−344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've always found it confusing that this code uses the word “sort” to describe partitioning candidates into buckets, since it isn't sorting them in the usual sense.
This PR therefore renames the relevant methods:
sort_candidates→partition_candidates_into_bucketssort_candidate→choose_bucket_for_candidateIn addition, this PR moves those methods into their own
bucketsmodule, updates some comments to reflect the renaming, and also makespartition_candidates_into_bucketsreturn a named struct instead of a tuple.There should be no change to compiler behaviour.