Modify x setup to choose pre-push hook with spellcheck #149961
+113
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Shunpoco
force-pushed
the
add-optional-spellcheck-in-pre-hook
branch
2 times, most recently
from
969f85c to
85db7e7
Compare
It changes setup for pre-push hook to use 3 options (tidy, with spellcheck, and skip). Since spellceck binary is installed everytime under ./build if the user clean up the build folder, it should be optional.
Shunpoco
force-pushed
the
add-optional-spellcheck-in-pre-hook
branch
from
85db7e7 to
69df709
Compare
Contributor
Author
|
r? @Kobzol |
Collaborator
|
|
rustbot
added
S-waiting-on-review
Shunpoco
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://rust-lang.zulipchat.com/#narrow/channel/326414-t-infra.2Fbootstrap/topic/Should.20Spellcheck.20check.20all.20files.3F/with/543227610
It changes setup for pre-push hook to use 3 options (tidy, with spellcheck, and skip). Since spellceck binary is installed under ./build whenever if the user clean up the build folder, it should be optional.