Add Tier 3 Thumb-mode targets for Armv7-A, Armv7-R and Armv8-R #150556
+231
−125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb These commits modify compiler targets. |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
Member
|
@rustbot reroll |
This comment was marked as resolved.
This comment was marked as resolved.
thejpster
force-pushed
the
add-thumbv7a-thumbv7r-thumbv8r
branch
from
a338091 to
a556210
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
|
wooops, sry @bors compiler |
Contributor
|
Unknown command "compiler". Run |
Contributor
|
@rustbot reroll |
petrochenkov
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
thejpster
force-pushed
the
add-thumbv7a-thumbv7r-thumbv8r
branch
from
809a1a5 to
fb05cac
Compare
thejpster
force-pushed
the
add-thumbv7a-thumbv7r-thumbv8r
branch
from
75afffe to
fa526c4
Compare
Contributor
Author
|
@petrochenkov - I've updated the docs as requested. |
petrochenkov
added
S-waiting-on-review
Contributor
|
Thanks! |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have targets for bare-metal Armv7-R, Armv7-A and Armv8-R, but only in Arm mode. This PR adds five new targets enabling bare-metal support on these architectures in Thumb mode.
This has been tested using https://github.com/rust-embedded/aarch32/compare/main...thejpster:aarch32:support-thumb-mode-v7-v8?expand=1 and they all seem to work as expected.
However, I wasn't sure what to do with the maintainer lists as these are five new targets, but they share the docs page with the existing Arm versions. I can ask the Embedded Devices WG Arm Team about taking on these ones too, but whether Arm themselves want to take them on I guess is a bigger question.