Skip to content

dirfd file operations (2/4) #150679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Qelxiros wants to merge 1 commit into
base: main
Choose a base branch
from
Open

dirfd file operations (2/4) #150679

Qelxiros wants to merge 1 commit into from

Conversation

@Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Jan 4, 2026 •
edited by rustbot
Loading

Previous PR: #146341
Reference: #139514
Tracking issue: #120426

@rustbot rustbot added O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 4, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2026

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Qelxiros
Copy link
Contributor Author

Qelxiros commented Jan 4, 2026

This is going to need a try run for windows at least. @tgross35 I'll let you decide which jobs make the most sense here.

@tgross35
Copy link
Contributor

tgross35 commented Jan 4, 2026

@bors2 try jobs=x86_64-msvc-*

Cc @the8472 for dirfd, and @ChrisDenton for Windows

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Jan 4, 2026
@rust-bors
Auto merge of #150679 - Qelxiros:dirfd-files, r=<try>
796e04e 
dirfd file operations (2/4)

try-job: x86_64-msvc-*
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 5, 2026

☀️ Try build successful (CI)
Build commit: 796e04e (796e04e9c306cfa50aa215b1e93ebdb1cbdc51d8, parent: e29fcf45e4ae686d77b490bf07320f0d3a2cf35f)

@rust-bors

This comment has been minimized.

Sign in to view
@tgross35
Copy link
Contributor

tgross35 commented Jan 24, 2026

I haven't had a chance to look here yet, sorry

@rustbot reroll

@rustbot rustbot assigned ChrisDenton and unassigned tgross35 Jan 24, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ChrisDenton ChrisDenton

Labels

O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Qelxiros @rustbot @tgross35 @ChrisDenton