Skip to content

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Jan 8, 2026

Same rationale as #136642.

@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 8, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 8, 2026

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the std_detect_split_tests branch from 9da3959 to 2aef964 Compare January 8, 2026 16:09
@clubby789
Copy link
Contributor

Bootstrap changes look fine to me, so r? libs

@rustbot rustbot assigned jhpratt and unassigned clubby789 Jan 8, 2026
@rust-log-analyzer

This comment has been minimized.

@jhpratt
Copy link
Member

jhpratt commented Jan 9, 2026

r? libs

@rustbot rustbot assigned tgross35 and unassigned jhpratt Jan 9, 2026
@bjorn3 bjorn3 force-pushed the std_detect_split_tests branch from 2aef964 to bc1d73e Compare January 9, 2026 10:14
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the std_detect_split_tests branch from bc1d73e to 1013779 Compare January 9, 2026 10:23
@bjorn3 bjorn3 force-pushed the std_detect_split_tests branch from 1013779 to c18ed7b Compare January 11, 2026 11:18
@rustbot
Copy link
Collaborator

rustbot commented Jan 11, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me for the libs parts, but I'd like somebody more familiar with bootstrap to make sure there isn't anything missing.

r? bootstrap

View changes since this review

@rustbot rustbot assigned Zalathar and unassigned tgross35 Jan 24, 2026
@tgross35
Copy link
Contributor

To make sure things still build on some of the targets here

@bors try jobs=test-various

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 24, 2026
Move std_detect tests into a separate crate


try-job: test-various
@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 24, 2026

💔 Test for ae867f2 failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@tgross35
Copy link
Contributor

Looks like it needs a small fix
@rustbot author

@Zalathar
Copy link
Member

The std_detect_tests crate probably needs an explicit dependency on std_detect.

@bjorn3 bjorn3 force-pushed the std_detect_split_tests branch from c18ed7b to 49be58e Compare January 24, 2026 10:40
@bjorn3
Copy link
Member Author

bjorn3 commented Jan 24, 2026

Added

@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the std_detect_split_tests branch from 49be58e to 0b97a98 Compare January 24, 2026 11:55
@rust-log-analyzer

This comment has been minimized.

@bjorn3 bjorn3 force-pushed the std_detect_split_tests branch from 0b97a98 to bc56f5d Compare January 24, 2026 15:09
@bjorn3
Copy link
Member Author

bjorn3 commented Jan 24, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 24, 2026
Copy link
Contributor

@tgross35 tgross35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 24, 2026

📌 Commit bc56f5d has been approved by tgross35

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2026
…gross35

Move std_detect tests into a separate crate

Same rationale as rust-lang#136642.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2026
…gross35

Move std_detect tests into a separate crate

Same rationale as rust-lang#136642.
@matthiaskrgr
Copy link
Member

cranelift not in rust.codegen-backends. skipping
gcc not in rust.codegen-backends. skipping
Building stage1 library artifacts (stage1 -> stage1, x86_64-unknown-linux-gnu)
    Finished `dist` profile [optimized] target(s) in 0.04s
Testing stage1 {alloc, alloctests, compiler_builtins, core, coretests, panic_abort, panic_unwind, proc_macro, rustc-std-workspace-core, std, std_detect, std_detect_tests, sysroot, test, unwind} (x86_64-unknown-linux-gnu)
   Compiling rand_core v0.9.3
   Compiling alloctests v0.0.0 (/home/matthias/vcs/github/rust/library/alloctests)
   Compiling coretests v0.0.0 (/home/matthias/vcs/github/rust/library/coretests)
   Compiling std_detect v0.1.5 (/home/matthias/vcs/github/rust/library/std_detect)
   Compiling std_detect_tests v0.0.0 (/home/matthias/vcs/github/rust/library/std_detect_tests)
   Compiling proc_macro v0.0.0 (/home/matthias/vcs/github/rust/library/proc_macro)
   Compiling test v0.0.0 (/home/matthias/vcs/github/rust/library/test)
error[E0432]: unresolved import `std_detect::detect::__test_os`
 --> library/std_detect_tests/tests/auxvec.rs:4:25
  |
4 | use std_detect::detect::__test_os::{auxv, auxv_from_file};
  |                         ^^^^^^^^^ could not find `__test_os` in `detect`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `std_detect_tests` (test "auxvec") due to 1 previous error
warning: build failed, waiting for other jobs to finish...
Build completed unsuccessfully in 0:04:59

looks related to this pr? 🤔

@bjorn3
Copy link
Member Author

bjorn3 commented Jan 24, 2026

Yes

@bors r-

@rust-bors rust-bors bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 24, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 24, 2026

Commit bc56f5d has been unapproved.

@rust-bors rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants