Skip to content

Port #[patchable_function_entry] to attr parser #151340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 2 commits into from
Jan 21, 2026
Merged

Port #[patchable_function_entry] to attr parser #151340

rust-bors merged 2 commits into from
Jan 21, 2026
+412 −357

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Jan 18, 2026 •
edited
Loading

This is the last codegen attr (see #151335 and #151336)!

Tracking issue: #131229

currently this PR is rebased on #151336 to make CI pass for the last commit

to see the actual changes in this PR you can look here

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2026

Error: Parsing assign command in comment failed: ...' @' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@Bryntet Bryntet force-pushed the port_patchable_function_entry branch from f36627d to 52bf01f Compare January 19, 2026 09:42
@Bryntet
Copy link
Contributor Author

Bryntet commented Jan 19, 2026

r? @JonathanBrouwer

would like review in the current state, it's not ready to merge though until #151336 is through, and then I'll add another commit making a let Some(attribute::Parsed(attr)) = attr else {continue;} in compiler/rustc_codegen_ssa/src/codegen_attrs.rs since this is the last unparsed codegenned attr done :)

@Bryntet Bryntet marked this pull request as ready for review January 19, 2026 10:10
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2026
@Bryntet Bryntet force-pushed the port_patchable_function_entry branch from 52bf01f to 4c9dfab Compare January 19, 2026 10:11
@Bryntet
Copy link
Contributor Author

Bryntet commented Jan 19, 2026

actually I'll rebase this on #151336 so the whole PR can be reviewed in it's entirety right now, so ignore those first two commits until it's merged into main

@Bryntet Bryntet force-pushed the port_patchable_function_entry branch 2 times, most recently from 70485f5 to 55111fb Compare January 19, 2026 10:27
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryntet Bryntet force-pushed the port_patchable_function_entry branch from 55111fb to fe7430c Compare January 19, 2026 11:27
@JonathanBrouwer JonathanBrouwer added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 19, 2026
@JonathanBrouwer JonathanBrouwer force-pushed the port_patchable_function_entry branch from fe7430c to 0917c59 Compare January 19, 2026 17:14
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@JonathanBrouwer JonathanBrouwer removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Jan 19, 2026
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 19, 2026
Open
9 tasks
JonathanBrouwer
JonathanBrouwer reviewed Jan 19, 2026
View reviewed changes
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 19, 2026

I rebased the PR to make reviewing easier.

@bors delegate
r=me after fixing my comment

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

✌️ @Bryntet, you can now approve this pull request!

If @JonathanBrouwer told you to "r=me" after making some further change, then please make that change and post @bors r=JonathanBrouwer.

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 19, 2026

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Bryntet Bryntet force-pushed the port_patchable_function_entry branch from 0917c59 to 79dba29 Compare January 19, 2026 21:18
@Bryntet
Copy link
Contributor Author

Bryntet commented Jan 19, 2026

@bors r=JonathanBrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

📌 Commit 79dba29 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 19, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 19, 2026

@bors r-
r=me with green ci

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 19, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 19, 2026

Commit 79dba29 has been unapproved.

@Bryntet Bryntet force-pushed the port_patchable_function_entry branch from 79dba29 to a0b3ee2 Compare January 20, 2026 10:46
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 20, 2026

@bors r+ rollup

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 20, 2026

📌 Commit a0b3ee2 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 20, 2026
@jhpratt jhpratt mentioned this pull request Jan 21, 2026
Merged
rust-bors bot pushed a commit that referenced this pull request Jan 21, 2026
@bors
Auto merge of #151436 - jhpratt:rollup-Rp5KtGe, r=jhpratt
88ad3d4 
Rollup of 6 pull requests

Successful merges:

 - #150436 (`c_variadic`: impl `va_copy` and `va_end` as Rust intrinsics)
 - #151340 (Port `#[patchable_function_entry]` to attr parser)
 - #151351 (Deduplicate diagnostics for const trait supertraits)
 - #151424 (missing colon after the compile-flags directive)
 - #151428 (Port variance attrs to attr parser.)
 - #151429 (s390x: Support aligned stack datalayout)

Failed merges:

 - #151343 (Port some crate level attrs to the attribute parser)

r? @ghost
@rust-bors rust-bors bot merged commit 79be7a0 into rust-lang:main Jan 21, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 21, 2026
rust-timer added a commit that referenced this pull request Jan 21, 2026
@rust-timer
Unrolled build for #151340
18b9e17 
Rollup merge of #151340 - port_patchable_function_entry, r=JonathanBrouwer

Port `#[patchable_function_entry]` to attr parser

This is the last codegen attr (see #151335 and #151336)!

Tracking issue: #131229

currently this PR is rebased on #151336 to make CI pass for the last commit

to see the actual changes in this PR you can look [here](https://github.com/rust-lang/rust/pull/151340/changes/3e731f7e84301a898a36e46ee5e4845ff9bda98a..55111fb468808b733e97170a841217a67666ac33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer left review comments

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Bryntet @rustbot @rust-log-analyzer @JonathanBrouwer