Reintroduce QueryStackFrame split.
#151390
Merged
+341
−149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-query-system
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
I want this in main ASAP |
This comment has been minimized.
This comment has been minimized.
Contributor
|
r? @petrochenkov |
petrochenkov
added
S-waiting-on-author
I tried removing it in rust-lang#151203, to replace it with something simpler. But a couple of fuzzing failures have come up and I don't have a clear picture on how to fix them. So I'm reverting the main part of rust-lang#151203. This commit also adds the two fuzzing tests. Fixes rust-lang#151226, rust-lang#151358.
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
Contributor
Author
|
@bors r=petrochenkov |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 27, 2026
Reintroduce `QueryStackFrame` split. I tried removing it in rust-lang#151203, to replace it with something simpler. But a couple of fuzzing failures have come up and I don't have a clear picture on how to fix them. So I'm reverting the main part of rust-lang#151203. This commit also adds the two fuzzing tests. Fixes rust-lang#151226, rust-lang#151358. r? @oli-obk
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Jan 27, 2026
Reintroduce `QueryStackFrame` split. I tried removing it in rust-lang#151203, to replace it with something simpler. But a couple of fuzzing failures have come up and I don't have a clear picture on how to fix them. So I'm reverting the main part of rust-lang#151203. This commit also adds the two fuzzing tests. Fixes rust-lang#151226, rust-lang#151358. r? @oli-obk
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Rollup of 5 pull requests Successful merges: - #151692 (Try to reduce rustdoc GUI tests flakyness) - #147436 (slice/ascii: Optimize `eq_ignore_ascii_case` with auto-vectorization) - #151390 (Reintroduce `QueryStackFrame` split.) - #151097 (Use an associated type default for `Key::Cache`.) - #151702 (Omit standard copyright notice)
rust-timer
added a commit
that referenced
this pull request
Jan 27, 2026
Rollup merge of #151390 - nnethercote:revert, r=petrochenkov Reintroduce `QueryStackFrame` split. I tried removing it in #151203, to replace it with something simpler. But a couple of fuzzing failures have come up and I don't have a clear picture on how to fix them. So I'm reverting the main part of #151203. This commit also adds the two fuzzing tests. Fixes #151226, #151358. r? @oli-obk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried removing it in #151203, to replace it with something simpler. But a couple of fuzzing failures have come up and I don't have a clear picture on how to fix them. So I'm reverting the main part of #151203.
This commit also adds the two fuzzing tests.
Fixes #151226, #151358.
r? @oli-obk