compiler: Require mir_opt_level > 1 for SingleUseConsts MIR pass
#151426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
Enselic
changed the title
Enselic
force-pushed
the
single-use-consts-mir-opt-level
branch
from
3c16dbc to
2be3ec0
Compare
Enselic
force-pushed
the
single-use-consts-mir-opt-level
branch
from
2be3ec0 to
6b292c7
Compare
Enselic
changed the title
mir-opt-level > 1 for SingleUseConsts
Enselic
changed the title
mir-opt-level > 1 for SingleUseConstsSingleUseConsts
This comment has been minimized.
This comment has been minimized.
To make `tests/debuginfo/basic-stepping.rs` pass.
Note that we must keep `SingleUseConsts` enabled for
`tests/ui-fulldeps/rustc_public/check_allocation.rs` since its
`fn collect_consts()` assumes that:
VarDebugInfo {
name: "_false",
[...]
value: Place(
_5,
),
}
is transformed into which is what `SingleUseConsts` does:
VarDebugInfo {
name: "_false",
[...]
value: Const(
[...]
),
}
Enselic
force-pushed
the
single-use-consts-mir-opt-level
branch
from
6b292c7 to
d7fffab
Compare
Enselic
changed the title
SingleUseConstsmir_opt_level > 1 for SingleUseConsts MIR pass
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make
tests/debuginfo/basic-stepping.rspass.Note that we must keep
SingleUseConstsenabled fortests/ui-fulldeps/rustc_public/check_allocation.rssince itsfn collect_consts()assumes that:is transformed into which is what
SingleUseConstsdoes:Closes: #33013
CC author @celinval and reviewer @ouz-a of 0a0e7e6 that can maybe help me determine if my fix to tests/ui-fulldeps/rustc_public/check_allocation.rs is acceptable. Thanks!