Add new unstable attribute: #[export_visibility = ...].
#151431
Conversation
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-compiler
|
r? @chenyukang rustbot has assigned @chenyukang. Use |
|
i had a quick look, mostly looks good, but i'd like to maybe @JonathanBrouwer take a look on this as well, i may overlooked something r? JonathanBrouwer |
|
Would like to take a look, will do so tomorrow :) |
|
☔ The latest upstream changes (presumably #151436) made this pull request unmergeable. Please resolve the merge conflicts. |
| const ATTRIBUTE_ORDER: AttributeOrder = AttributeOrder::KeepInnermost; | ||
| const ON_DUPLICATE: OnDuplicate<S> = OnDuplicate::Error; | ||
| const ALLOWED_TARGETS: AllowedTargets = | ||
| AllowedTargets::AllowListWarnRest(&[Allow(Target::Fn), Allow(Target::Static)]); |
There was a problem hiding this comment.
Is there a reason you choose WarnRest here?
I'd prefer for new attributes to default to AllowedTargets::AllowList.
| return None; | ||
| }; | ||
| let Ok(visibility) = ExportVisibilityAttrValue::from_str(sv.as_str()) else { | ||
| cx.emit_err(InvalidExportVisibility { |
There was a problem hiding this comment.
Could this use cx.expected_specific_argument_strings instead?
(not sure)
| export_visibility_span, | ||
| "#[export_visibility = ...]` will be ignored without \ | ||
| `export_name`, `no_mangle`, or similar attribute", | ||
| ); |
There was a problem hiding this comment.
Can we make these struct errors?
In my opinion these are still nicer for simple errors like this. If you strongly disagree feel free to keep them like this
| fn from_str(s: &str) -> Result<ExportVisibilityAttrValue, Self::Err> { | ||
| match s { | ||
| "target_default" => Ok(ExportVisibilityAttrValue::TargetDefault), | ||
| _ => Err(format!("'{s}' is not a valid value for #[export_visibility = ...]",)), |
There was a problem hiding this comment.
Is this string used anywhere? If not, could we make the Err type ()?
| EiiImpls(..) => No, | ||
| ExportName { .. } => Yes, | ||
| ExportStable => No, | ||
| ExportVisibility { .. } => Yes, |
There was a problem hiding this comment.
Is exporting this attribute needed? (Not sure, genuine question)
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
5 participants
This PR is an implementation of the RFC tracked in #151425