Skip to content

Port #![crate_type] to the attribute parser #151442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rust-bors merged 4 commits into from
Jan 22, 2026
Merged

Port #![crate_type] to the attribute parser #151442

rust-bors merged 4 commits into from
Jan 22, 2026
+627 −466

Conversation

@clubby789
Copy link
Contributor

@clubby789 clubby789 commented Jan 21, 2026 •
edited
Loading

Tracking issue: #131229

Note that the actual parsing that is used in the compiler session is unchanged, as it must happen very early on; this just ports the validation logic.

Also added // tidy-alphabetical-start to check_attr.rs to make it a bit less conflict-prone

@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 21, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2026

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 21, 2026

r? me

JonathanBrouwer
JonathanBrouwer reviewed Jan 21, 2026
View reviewed changes
JonathanBrouwer
JonathanBrouwer reviewed Jan 21, 2026
View reviewed changes
JonathanBrouwer
JonathanBrouwer reviewed Jan 21, 2026
View reviewed changes
JonathanBrouwer
JonathanBrouwer reviewed Jan 21, 2026
View reviewed changes
JonathanBrouwer
JonathanBrouwer requested changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor questions, looks good otherwise :)

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 21, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rust-bors

This comment has been minimized.

Sign in to view
JonathanBrouwer
JonathanBrouwer reviewed Jan 21, 2026
View reviewed changes
@clubby789 clubby789 force-pushed the crate-type-port branch 2 times, most recently from 6bd6665 to 1c820c0 Compare January 21, 2026 17:07
@rustbot

This comment has been minimized.

Sign in to view
@clubby789 clubby789 mentioned this pull request Jan 21, 2026
Open
9 tasks
@clubby789
Copy link
Contributor Author

clubby789 commented Jan 21, 2026

@rustbot ready

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 21, 2026

☀️ Try build successful (CI)
Build commit: d813a87 (d813a8744eff9f546c98445f2bebdb05c5435e1f, parent: daa90b96dd039ce0c5708408972e2af45990c1db)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Jan 22, 2026

Finished benchmarking commit (d813a87): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.4%, secondary 1.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 2.4% [1.3%, 3.4%] 2
Regressions ❌
(secondary)		 1.7% [0.8%, 4.2%] 4
Improvements ✅
(primary)		 -0.6% [-0.6%, -0.6%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 1.4% [-0.6%, 3.4%] 3

Cycles

Results (secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 6.3% [5.5%, 7.2%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.6%, -2.1%] 2
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.203s -> 471.246s (0.22%)
Artifact size: 383.19 MiB -> 383.17 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 22, 2026
@clubby789
Copy link
Contributor Author

clubby789 commented Jan 22, 2026

Looks like noise - @bors r=JonathanBrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 22, 2026

📌 Commit 21f97f0 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 22, 2026
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@clubby789
Copy link
Contributor Author

clubby789 commented Jan 22, 2026

@bors r=JonathanBrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 22, 2026

📌 Commit e73dfaa has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 22, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 22, 2026

@bors rollup=always

@jhpratt jhpratt mentioned this pull request Jan 22, 2026
Merged
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jan 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#151442 - clubby789:crate-type-port, r=Jonat…
105b934 
…hanBrouwer

Port `#![crate_type]` to the attribute parser

Tracking issue: rust-lang#131229

~~Note that the actual parsing that is used in the compiler session is unchanged, as it must happen very early on; this just ports the validation logic.~~

Also added `// tidy-alphabetical-start` to `check_attr.rs` to make it a bit less conflict-prone
@JonathanBrouwer JonathanBrouwer mentioned this pull request Jan 22, 2026
Closed
rust-bors bot pushed a commit that referenced this pull request Jan 22, 2026
@bors
Auto merge of #151480 - jhpratt:rollup-kUkiF2m, r=jhpratt
d29e478 
Rollup of 4 pull requests

Successful merges:

 - #151118 (Support slices in type reflection)
 - #151439 (Bump bootstrap compiler to 1.94)
 - #151442 (Port `#![crate_type]` to the attribute parser)
 - #151457 (Improve error message for assert!() macro in functions returning bool)

r? @ghost
@rust-bors rust-bors bot merged commit 512cc8d into rust-lang:main Jan 22, 2026
11 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 22, 2026
rust-timer added a commit that referenced this pull request Jan 22, 2026
@rust-timer
Unrolled build for #151442
d888ff8 
Rollup merge of #151442 - clubby789:crate-type-port, r=JonathanBrouwer

Port `#![crate_type]` to the attribute parser

Tracking issue: #131229

~~Note that the actual parsing that is used in the compiler session is unchanged, as it must happen very early on; this just ports the validation logic.~~

Also added `// tidy-alphabetical-start` to `check_attr.rs` to make it a bit less conflict-prone
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Urgau Urgau Urgau left review comments

@JonathanBrouwer JonathanBrouwer JonathanBrouwer requested changes

Assignees

@JonathanBrouwer JonathanBrouwer

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.95.0

Development

Successfully merging this pull request may close these issues.

7 participants

@clubby789 @rustbot @JonathanBrouwer @rust-timer @Urgau @nnethercote @jamie-osec