Minor structural improvements #151474
Minor structural improvements #151474
Conversation
rustbot
added
S-waiting-on-review
|
The background here is I saw this blog post: https://pdh11.blogspot.com/2024/09/rust-circular-dependencies.html. It provides a script built on top of cargo-modules that identifies circular dependencies between modules. I tried it on the compiler and there are bazillions of what I think are harmless circular dependencies. E.g. it's very common for a crate root module to define lots of basic types, and then a submodule to use one or more of those types. Nonetheless, when I was looking through the generated dependency graphs I did notice a few suboptimal file layout things, which this PR fixes. |
This comment has been minimized.
This comment has been minimized.
It contains the `Cursor` type and an `impl Cursor` block with a few methods. But there is a larger `impl Cursor` block in the crate root. The only other thing in the `cursor` module is the simple `FrontmatterAllowed` type. So this commit just moves everything in the `cursor` module (which isn't much) into the crate root.
Every diagnostic struct in `rustc_parse` is in the `errors` module, except for `ForbiddenLetReason` and `MisspelledKw`. There's no good reason for this, and presumably it is just an accidental inconsistency. This commit moves them into `errors`.
From the `parser` module to the `errors` module, which is where most of its uses are. This means the `errors` module no longer depends on the `parser` module, removing a cyclic dependency between the two modules.
nnethercote
force-pushed
the
circ-deps
branch
from
93f7de1 to
b33fdb2
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
3 participants
Some small cleanups.
r? @davidtwco