Skip to content

Do not emit errors on non-metaitem diagnostic attr input #151516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mejrs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not emit errors on non-metaitem diagnostic attr input #151516

mejrs wants to merge 1 commit into from
+90 −62

Conversation

@mejrs
Copy link
Contributor

@mejrs mejrs commented Jan 22, 2026

This unblocks porting over diagnostic attributes by properly addressing #151056 (comment)

r? @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Jan 22, 2026

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 22, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 22, 2026
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jan 22, 2026

r? me I can finish this one tomorrow morning, looked through most of it already just now

@mejrs mejrs mentioned this pull request Jan 22, 2026
Open
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Jan 23, 2026

I'd also like to take a quick look at this before merging, will take a look in the afternoon today

JonathanBrouwer
JonathanBrouwer approved these changes Jan 23, 2026
View reviewed changes
Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good fix for the problem to me.
Will wait for Jana to also take a look, since she wanted to

View changes since this review

@mejrs mejrs mentioned this pull request Jan 23, 2026
Draft
@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jan 24, 2026

@bors r=jdonszelmann,jonathanbrouwer

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 24, 2026

📌 Commit 215a82c has been approved by jdonszelmann,jonathanbrouwer

It is now in the queue for this repository.

@jdonszelmann
Copy link
Contributor

jdonszelmann commented Jan 24, 2026

@bors rollup

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 24, 2026
@matthiaskrgr
Rollup merge of rust-lang#151516 - mejrs:ignore_nonmeta, r=jdonszelma…
ac8e7f2 
…nn,jonathanbrouwer

Do not emit errors on non-metaitem diagnostic attr input

This unblocks porting over diagnostic attributes by properly addressing rust-lang#151056 (comment)

r? @JonathanBrouwer
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 24, 2026
Open
rust-bors bot pushed a commit that referenced this pull request Jan 24, 2026
@bors
Auto merge of #151594 - matthiaskrgr:rollup-sAb1Qar, r=matthiaskrgr
021fc25 
Rollup of 4 pull requests

Successful merges:

 - #149174 (`const` blocks as a `mod` item)
 - #151282 (THIR patterns: Explicitly distinguish `&pin` from plain `&`/`&mut`)
 - #151593 (miri subtree update)
 - #151516 (Do not emit errors on non-metaitem diagnostic attr input)

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer approved these changes

Assignees

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mejrs @rustbot @jdonszelmann @JonathanBrouwer