Skip to content

Conversation

@weihanglo
Copy link
Member

14 commits in 85eff7c80277b57f78b11e28d14154ab12fcf643..efcd9f58636c1990393d495159045d9c35e43b8f
2026-01-15 16:18:08 +0000 to 2026-01-23 13:50:59 +0000

@weihanglo weihanglo self-assigned this Jan 23, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2026

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 23, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 23, 2026

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 23, 2026

📌 Commit eaf81e8 has been approved by weihanglo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 23, 2026
Update cargo submodule

14 commits in 85eff7c80277b57f78b11e28d14154ab12fcf643..efcd9f58636c1990393d495159045d9c35e43b8f
2026-01-15 16:18:08 +0000 to 2026-01-23 13:50:59 +0000
- chore(deps): update cargo-semver-checks to v0.46.0 (rust-lang/cargo#16548)
- Increase cache_lock test timeout (rust-lang/cargo#16545)
- iTerm now supports OSC 9;4 (terminal window progress bar) (rust-lang/cargo#16506)
- chore: Updated compiler errors for Rust 1.93 (rust-lang/cargo#16543)
- test(build-std): adjust snapshot (rust-lang/cargo#16539)
- chore: bump to 0.96.0 (rust-lang/cargo#16538)
- fix: update `resolve_all_features()` to filter pkg deps (rust-lang/cargo#16221)
- fix: show implicit_minimum_version_req emitted source once per package (rust-lang/cargo#16535)
- fix: `--remap-path-scope` stabilized in 1.95-nightly (rust-lang/cargo#16536)
- feat(lints): Add non_kebab_case_bin lint  (rust-lang/cargo#16524)
- fix(rm): Suggest table flags when none are specified (rust-lang/cargo#16533)
- fix(patch): clean up patch-related error messages (rust-lang/cargo#16498)
- Store artifact deps in build unit dir (rust-lang/cargo#16519)
- refactor(timings): reuse timing metric collection logic between `--timings` and `-Zbuild-analysis` (rust-lang/cargo#16497)
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    354d02aa29ac   4 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:596da3f22bcbdff2c96fd7126001278022c834c1621c5efa2ad1a7794590636c
deleted: sha256:354d02aa29acf525570c732b6e006ecf138de6d63ca525d552eb4b24880ddc6c
deleted: sha256:8b7af0e426bc2cbeeacfd96b8354d3b80016991520977197e62090e47abaede8
deleted: sha256:cadf11ef1de7fdd5eab563757942353684047f09b212dc99d6ed48e8acf34d62
deleted: sha256:569b0caf9d5285db44ccd2629a3470139eea755be423a33a54d8a24cb3926bfa
deleted: sha256:f9dc5feb048d8f9fd43137e3998f59e9acfbd76c47a4e14984d109654119e282
---
tests/ui/double_parens.rs ... ok
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/empty_docs.rs ... ok
tests/ui/eager_transmute.rs ... ok
---
..............................................     (146/146)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: The following errors happened: [Property named `"searchIndex"` doesn't exist]: for command `assert-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 23, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 23, 2026

💔 Test for 068b39e failed: CI. Failed job:

@weihanglo
Copy link
Member Author

Doesn't seem like a Cargo issue

https://triage.rust-lang.org/gha-logs/rust-lang/rust/61311247661#L2026-01-23T20:37:42.5321095Z-L2026-01-23T20:37:42.6157806Z

	error: mismatched closing delimiter: `}`
	##[error] --> tests/parser/unclosed-delims/issue_4466.rs:3:17
	  |
	2 |     if true {
	  |             - closing delimiter possibly meant for this
	3 |         println!("answer: {}", a_func();
	  |                 ^ unclosed delimiter
	4 |     } else {
	  |     ^ mismatched closing delimiter
	
	error: missing type for `static` item
	##[error] --> tests/parser/stashed-diag.rs:1:15
	  |
	1 | #![u={static N;}]
	  |               ^
	  |
	help: provide a type for the item
	  |
	1 | #![u={static N: <type>;}]
	  |               ++++++++
	
	test test::parser::crate_parsing_errors_on_unclosed_delims ... ok
	test test::parser::crate_parsing_stashed_diag ... ok
	error: this file contains an unclosed delimiter
	##[error] --> tests/parser/stashed-diag2.rs:3:14
	  |
	1 | trait Trait<'1> { s> {}
	  |                 - unclosed delimiter
	2 |
	3 | fn main() {}
	  |             ^
	
	error: lifetimes cannot start with a number
	##[error] --> tests/parser/stashed-diag2.rs:1:13
	  |
	1 | trait Trait<'1> { s> {}
	  |             ^^
	
	test test::parser::crate_parsing_stashed_diag2 ... ok
	error: unexpected closing delimiter: `}`
	##[error] --> tests/parser/issue_4418.rs:1:1
	  |
	1 | }
	  | ^ unexpected closing delimiter
	
	test test::parser::parser_creation_errors_on_entry_new_parser_from_file_panic ... ok
	test test::rustfmt_diff_make_diff_tests ... ok
	test test::rustfmt_diff_no_diff_test ... ok
	error: unexpected `if` in the condition expression
	##[error] --> tests/parser/issue-4126/invalid.rs:2:14
	  |
	2 |     if bar && if !baz {
	  |              ^^^^
	  |
	help: remove the `if`
	  |
	2 -     if bar && if !baz {
	2 +     if bar && !baz {
	  |
	
	test test::parser::parser_errors_in_submods_are_surfaced ... ok
	test test::stdin_disable_all_formatting_test ... ok
	test test::stdin_formatting_smoke_test ... ok
	test test::stdin_generated_files_issue_5172 ... ok
	test test::configuration_snippet::configuration_snippet_tests ... ok
	error: this file contains an unclosed delimiter
	##[error] --> <stdin>:1:2
	  |
	1 | {
	  | -^
	  | |
	  | unclosed delimiter
	
	error: unexpected closing delimiter: `}`
	##[error] --> <stdin>:1:1
	  |
	1 | }
	  | ^ unexpected closing delimiter

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 23, 2026
@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 23, 2026
Update cargo submodule

14 commits in 85eff7c80277b57f78b11e28d14154ab12fcf643..efcd9f58636c1990393d495159045d9c35e43b8f
2026-01-15 16:18:08 +0000 to 2026-01-23 13:50:59 +0000
- chore(deps): update cargo-semver-checks to v0.46.0 (rust-lang/cargo#16548)
- Increase cache_lock test timeout (rust-lang/cargo#16545)
- iTerm now supports OSC 9;4 (terminal window progress bar) (rust-lang/cargo#16506)
- chore: Updated compiler errors for Rust 1.93 (rust-lang/cargo#16543)
- test(build-std): adjust snapshot (rust-lang/cargo#16539)
- chore: bump to 0.96.0 (rust-lang/cargo#16538)
- fix: update `resolve_all_features()` to filter pkg deps (rust-lang/cargo#16221)
- fix: show implicit_minimum_version_req emitted source once per package (rust-lang/cargo#16535)
- fix: `--remap-path-scope` stabilized in 1.95-nightly (rust-lang/cargo#16536)
- feat(lints): Add non_kebab_case_bin lint  (rust-lang/cargo#16524)
- fix(rm): Suggest table flags when none are specified (rust-lang/cargo#16533)
- fix(patch): clean up patch-related error messages (rust-lang/cargo#16498)
- Store artifact deps in build unit dir (rust-lang/cargo#16519)
- refactor(timings): reuse timing metric collection logic between `--timings` and `-Zbuild-analysis` (rust-lang/cargo#16497)
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    354d02aa29ac   4 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:596da3f22bcbdff2c96fd7126001278022c834c1621c5efa2ad1a7794590636c
deleted: sha256:354d02aa29acf525570c732b6e006ecf138de6d63ca525d552eb4b24880ddc6c
deleted: sha256:8b7af0e426bc2cbeeacfd96b8354d3b80016991520977197e62090e47abaede8
deleted: sha256:cadf11ef1de7fdd5eab563757942353684047f09b212dc99d6ed48e8acf34d62
deleted: sha256:569b0caf9d5285db44ccd2629a3470139eea755be423a33a54d8a24cb3926bfa
deleted: sha256:f9dc5feb048d8f9fd43137e3998f59e9acfbd76c47a4e14984d109654119e282
---
tests/ui/double_parens.rs ... ok
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/elidable_lifetime_names.rs ... ok
---
..............................................     (146/146)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: The following errors happened: [Property named `"searchIndex"` doesn't exist]: for command `assert-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 23, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 23, 2026

💔 Test for 242a399 failed: CI. Failed job:

@weihanglo
Copy link
Member Author

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: The following errors happened: [Property named `"searchIndex"` doesn't exist]: for command `assert-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

I dont' think this is related. Lets try it once more.

@bors retry

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 24, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 24, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 24, 2026

☀️ Test successful - CI
Approved by: weihanglo
Duration: 3h 13m 51s
Pushing f134bbc to main...

@rust-bors rust-bors bot merged commit f134bbc into rust-lang:main Jan 24, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 24, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 021fc25 (parent) -> f134bbc (this PR)

Test differences

Show 24 test diffs

Stage 2

  • build_dir::artifact_deps: [missing] -> pass (J0)
  • build_dir_legacy::artifact_deps: [missing] -> pass (J0)
  • cargo_remove::invalid_section_missing_flags::case: [missing] -> pass (J0)
  • core::shell::tests::term_features_progress_detection: [missing] -> pass (J0)
  • features::dont_demand_not_required_dep: [missing] -> pass (J0)
  • lints::non_kebab_case_bin::bin_name_explicit: [missing] -> pass (J0)
  • lints::non_kebab_case_bin::bin_name_from_package: [missing] -> pass (J0)
  • lints::non_kebab_case_bin::bin_name_from_path: [missing] -> pass (J0)
  • lints::non_kebab_case_bin::bin_name_from_script_name: [missing] -> ignore (-Zscript is unstable) (J0)
  • patch::too_many_matches_in_git_repo: [missing] -> pass (J0)
  • profile_trim_paths::custom_build_env_var_trim_paths: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::diagnostics_works: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::git_dependency: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::multiple_options: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::object_works::with_split_debuginfo_packed: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::one_option: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::path_dependency: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::path_dependency_outside_workspace: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::profile_merge_works: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::registry_dependency: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::registry_dependency_with_build_script_codegen: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::release_profile_default_to_object: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J0)
  • profile_trim_paths::object_works::with_split_debuginfo_off: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J1)
  • profile_trim_paths::object_works::with_split_debuginfo_unpacked: ignore (-Zremap-path-scope is unstable) -> ignore (--remap-path-scope will be stabilized in 1.95) (J1)

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard f134bbc78dac04a17324341a8d4a15a6930d81a7 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-gnu-llvm-20-1: 3793.1s -> 3118.2s (-17.8%)
  2. aarch64-gnu-llvm-20-2: 3001.5s -> 2590.7s (-13.7%)
  3. aarch64-apple: 9834.6s -> 8675.8s (-11.8%)
  4. i686-gnu-nopt-1: 8277.5s -> 7346.8s (-11.2%)
  5. x86_64-mingw-2: 9581.3s -> 8553.1s (-10.7%)
  6. x86_64-gnu-miri: 4950.6s -> 4433.9s (-10.4%)
  7. arm-android: 6386.1s -> 5723.0s (-10.4%)
  8. pr-check-1: 1925.8s -> 1733.3s (-10.0%)
  9. dist-s390x-linux: 5326.5s -> 4817.1s (-9.6%)
  10. pr-check-2: 2503.5s -> 2269.8s (-9.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f134bbc): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.4%, secondary -2.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.4% [-2.7%, -2.0%] 2
All ❌✅ (primary) 2.4% [2.4%, 2.4%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.296s -> 472.065s (-0.05%)
Artifact size: 383.54 MiB -> 383.58 MiB (0.01%)

@weihanglo weihanglo deleted the update-cargo branch January 24, 2026 23:43
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
info: installing component 'cargo'
info: installing component 'rust-std'
info: installing component 'rustc'

  beta-2026-01-20-x86_64-unknown-linux-gnu installed - rustc 1.94.0-beta.1 (9b1f8ff42 2026-01-19)

info: using existing install for 'beta-2026-01-20-x86_64-unknown-linux-gnu'
info: default toolchain set to 'beta-2026-01-20-x86_64-unknown-linux-gnu'

  beta-2026-01-20-x86_64-unknown-linux-gnu unchanged - rustc 1.94.0-beta.1 (9b1f8ff42 2026-01-19)

##[group]Run ./src/tools/update-lockfile.sh
./src/tools/update-lockfile.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
dep-bumps
following is the output from `cargo update`:
  COMMIT_MESSAGE: cargo update 
##[endgroup]
./src/tools/update-lockfile.sh: 7: set: Illegal option -o pipefail
##[error]Process completed with exit code 2.
Post job cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants