Skip to content

Conversation

@Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 24, 2026

This checks that dep node dependencies are colored as expected after execution. It also marks no_hash queries with the expected color, similarly to #150156.

I was thinking this might be useful as a sample based sanity check.

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 24, 2026
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 25, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Jan 25, 2026
Check that dependencies colors are as expected after query execution
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 25, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 25, 2026

☀️ Try build successful (CI)
Build commit: 494092e (494092e44909ce3fb9b29de7db227caf02fc6118, parent: f134bbc78dac04a17324341a8d4a15a6930d81a7)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (494092e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.3% [0.2%, 0.9%] 36
Regressions ❌
(secondary)
0.4% [0.0%, 0.9%] 71
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.0%] 3
All ❌✅ (primary) 0.3% [0.2%, 0.9%] 36

Max RSS (memory usage)

Results (secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.8% [0.9%, 2.7%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.6% [-6.9%, -4.7%] 6
All ❌✅ (primary) - - 0

Cycles

Results (primary -0.3%, secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.9% [1.9%, 1.9%] 1
Regressions ❌
(secondary)
3.8% [3.0%, 4.9%] 3
Improvements ✅
(primary)
-1.4% [-2.0%, -0.8%] 2
Improvements ✅
(secondary)
-4.6% [-6.7%, -3.2%] 4
All ❌✅ (primary) -0.3% [-2.0%, 1.9%] 3

Binary size

Results (primary 0.0%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 4
Regressions ❌
(secondary)
0.0% [0.0%, 0.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 4

Bootstrap: 472.065s -> 481.54s (2.01%)
Artifact size: 383.58 MiB -> 385.98 MiB (0.63%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 25, 2026
@rust-bors

This comment has been minimized.

@Zoxc Zoxc force-pushed the post-exec-color-check branch from 409d6e3 to e4a9375 Compare January 25, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants