Rollup of 4 pull requests #151678
Closed
Rollup of 4 pull requests #151678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other hints have a note recommending benchmarks to ensure they actually do what is intended. This is also applicable for `cold_path`, so add a note here.
Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of non-essential deref magic.
These were split from the `cold_path` tracking issue.
To minimize the diff when adding features the aux `proc-macro` directive.
Do not return incorrectly constrained opaques in `method_autoderef_steps` Fixes rust-lang/trait-system-refactor-initiative#263 r? @lcnr
Update documentation for `cold_path`, `likely`, and `unlikely` * Add a note recommending benchmarks to `cold_path`, as other hints have * Note that `cold_path` can be used to implement `likely` and `unlikely` * Update the tracking issue for the `likely_unlikely` feature Tracking issue: rust-lang#136873 Tracking issue: rust-lang#151619
Remove `Deref<Target = TyCtxt>` from `QueryCtxt` Explicitly writing `self.tcx` is easy enough, and lets us remove a bit of non-essential deref magic.
compiletest: Parse aux `proc-macro` directive into struct This PR does not introduce any changes. It is pure refactoring to make PR rust-lang#151258 smaller so it is easier to see what that PR is about, as discussed [here](rust-lang#151258 (comment)). r? @Zalathar
rustbot
added
A-compiletest
Member
Author
|
Oh never mind; I thought #151674 had flaked out, but it was only PR CI that flaked out (network 500 error). |
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
method_autoderef_steps#151676 (Do not return incorrectly constrained opaques inmethod_autoderef_steps)cold_path,likely, andunlikely#151612 (Update documentation forcold_path,likely, andunlikely)Deref<Target = TyCtxt>fromQueryCtxt#151626 (RemoveDeref<Target = TyCtxt>fromQueryCtxt)proc-macrodirective into struct #151670 (compiletest: Parse auxproc-macrodirective into struct)r? @ghost
Create a similar rollup