Update backtrace and windows-bindgen #151680
Merged
+173
−173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-tidy
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use |
rustbot
added
T-bootstrap
Collaborator
|
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
This comment was marked as resolved.
This comment was marked as resolved.
tgross35
approved these changes
Jan 26, 2026
Contributor
There was a problem hiding this comment.
Context for the windows-link change at rust-lang/backtrace-rs#727 / rust-lang/backtrace-rs#694. Sanity checking Windows, r=me after that
@bors try jobs=x86_64-msvc-*
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
Update backtrace and windows-bindgen try-job: x86_64-msvc-*
This comment has been minimized.
This comment has been minimized.
rust-bors
bot
added
S-waiting-on-author
Contributor
|
💔 Test for 401b150 failed: CI. Failed job:
|
Member
Author
|
That's weird. Is github having issues? @bors try jobs=x86_64-msvc-* |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
Update backtrace and windows-bindgen try-job: x86_64-msvc-*
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
Author
|
@bors try jobs=x86_64-msvc-* |
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 26, 2026
Update backtrace and windows-bindgen try-job: x86_64-msvc-*
This comment has been minimized.
This comment has been minimized.
Contributor
|
I think rla may have been responding to the previous failure, the retry was still ongoing. Since at least the ext jobs succeeded, I expect this to be fine. @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
rust-bors bot
pushed a commit
that referenced
this pull request
Jan 27, 2026
Rollup of 12 pull requests Successful merges: - #147996 (Stabilize ppc inline assembly) - #148718 (Do not mention `-Zmacro-backtrace` for std macros that are a wrapper around a compiler intrinsic) - #151137 (checksum-freshness: Fix invalid checksum calculation for binary files) - #151680 (Update backtrace and windows-bindgen) - #150863 (Adds two new Tier 3 targets - `aarch64v8r-unknown-none{,-softfloat}`) - #151040 (Don't expose redundant information in `rustc_public`'s `LayoutShape`) - #151383 (remove `#[deprecated]` from unstable & internal `SipHasher13` and `24` types) - #151529 (lint: Use rustc_apfloat for `overflowing_literals`, add f16 and f128) - #151669 (rename uN::{gather,scatter}_bits to uN::{extract,deposit}_bits) - #151689 (Fix broken Xtensa installation link) - #151699 (Update books) - #151700 (os allow missing_docs)
rust-timer
added a commit
that referenced
this pull request
Jan 27, 2026
Rollup merge of #151680 - ChrisDenton:bindgen, r=tgross35 Update backtrace and windows-bindgen Supersedes the backtrace bump in #151659 This is mostly just renaming `windows_targets` to `windows_link` but it needs to be done in tandem with the backtrace submodule update. The reason for doing this is that backtrace is both copy/pasted into std (via being a submodule) and published as an independent crate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes the backtrace bump in #151659
This is mostly just renaming
windows_targetstowindows_linkbut it needs to be done in tandem with the backtrace submodule update. The reason for doing this is that backtrace is both copy/pasted into std (via being a submodule) and published as an independent crate.