-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Use fewer intermediate functions for short backtraces in queries #151739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If we make sure that `compute_fn` in the query's vtable is actually named `__rust_begin_short_backtrace`, we can avoid the need for some additional intermediate functions and stack frames. This is similar to how the `get_query_incr` and `get_query_non_incr` functions are actually named `__rust_end_short_backtrace`.
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
|
Let's have another perf run for the non-draft PR: @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Use fewer intermediate functions for short backtraces in queries
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (21dc8d7): comparison URL. Overall result: ❌✅ regressions and improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -1.6%, secondary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 1.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 472.873s -> 474.195s (0.28%) |
If we make sure that
compute_fnin the query's vtable is actually named__rust_begin_short_backtrace, we can avoid the need for some additional intermediate functions and stack frames.This is similar to how the
get_query_incrandget_query_non_incrfunctions are actually named__rust_end_short_backtrace.