-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Rollup of 4 pull requests #151749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #151749
Conversation
This allows the `types` macro to easily implement `From<Simd<T, N>>` and `Into<Simd<T, N>>`
…oid-unsafe-tests Use a generic type to implement SIMD types in `core_arch::simd` and avoid `unsafe fn` in more tests
For other targets we don't have such instances. We specifically decided agains implementing arithmetic operators on these low-level vector types
The inline(always) attribute is now applied to the call site when a function has target features enabled so that it can determine that the call is safe to inline.
thread, grid, and block dim/idx can only return non-negative values
remove `impl Neg` on s390x/powerpc vector types
Mark the neon intrinsics as inline(always).
use `simd_extract_dyn` for `extract`
Because `qemu` does not support these (yet), I haven't added any runtime tests
s390x: add `nnp-assist` intrinsics
test `vmulh_lane_f16` in intrinsic test
Stabilize `__jcvt`
This updates the rust-version file to 873d468.
Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@873d468 Filtered ref: rust-lang/stdarch@003d326 Upstream diff: rust-lang/rust@4862272...873d468 This merge was created using https://github.com/rust-lang/josh-sync.
Rustc pull update
use `simd_splat`
|
@bors r+ rollup=never p=5 |
This comment has been minimized.
This comment has been minimized.
|
📌 Perf builds for each rolled up PR:
previous master: 94a0cd15f5 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 94a0cd1 (parent) -> e96bb7e (this PR) Test differencesShow 6 test diffsStage 1
Stage 2
Additionally, 2 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard e96bb7e44fbcc23c1e6009e8d0ee8ab208668fb4 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (e96bb7e): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.5%, secondary 1.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -1.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 473.018s -> 470.891s (-0.45%) |
|
We have an unexpected perf improvement, yay. Maybe #151694? @rust-timer build ce5409c |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (ce5409c): comparison URL. Overall result: ❌ regressions - no action neededInstruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.018s -> 473.507s (0.10%) |
|
@rust-timer build 8d0fe88 |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (8d0fe88): comparison URL. Overall result: no relevant changes - no action neededInstruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -5.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.2%, secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 473.018s -> 472.846s (-0.04%) |
Successful merges:
sys#151161 (std: move time implementations tosys)proc_macrobridge cleanups #151694 (moreproc_macrobridge cleanups)r? @ghost
Create a similar rollup