Skip to content

Conversation

@JonathanBrouwer
Copy link
Contributor

Successful merges:

r? @ghost

Create a similar rollup

ZuseZ4 and others added 30 commits December 9, 2025 10:52
This allows the `types` macro to easily implement `From<Simd<T, N>>` and `Into<Simd<T, N>>`
…oid-unsafe-tests

Use a generic type to implement SIMD types in `core_arch::simd` and avoid `unsafe fn` in more tests
For other targets we don't have such instances. We specifically decided agains implementing arithmetic operators on these low-level vector types
The inline(always) attribute is now applied to the call site when a
function has target features enabled so that it can determine that the
call is safe to inline.
thread, grid, and block dim/idx can only return non-negative values
remove `impl Neg` on s390x/powerpc vector types
Mark the neon intrinsics as inline(always).
Because `qemu` does not support these (yet), I haven't added any runtime tests
This updates the rust-version file to 873d468.
@rustbot rustbot added O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue. labels Jan 27, 2026
@JonathanBrouwer
Copy link
Contributor Author

@bors r+ rollup=never p=5

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

📌 Commit 53fb684 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 27, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 27, 2026

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 23m 58s
Pushing e96bb7e to main...

@rust-bors rust-bors bot merged commit e96bb7e into rust-lang:main Jan 27, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 27, 2026
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#150557 Don't try to evaluate const blocks during constant promotion 8d0fe88ffa814dcdb29368a0ab6a8e9aee1ba15d (link)
#151161 std: move time implementations to sys cd13f942328e436d0704cafd97e522acd93cf333 (link)
#151694 more proc_macro bridge cleanups ce5409c2ca9d7b95a1aa646716269c6be06f5881 (link)
#151711 stdarch subtree update 192c8ae6f9513ce9bb7943a5a61c39cd7935d06e (link)

previous master: 94a0cd15f5

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 94a0cd1 (parent) -> e96bb7e (this PR)

Test differences

Show 6 test diffs

Stage 1

  • [ui] tests/ui/inline-const/dont-eval-const-block-during-promotion.rs#fail: [missing] -> pass (J1)
  • [ui] tests/ui/inline-const/dont-eval-const-block-during-promotion.rs#pass: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/inline-const/dont-eval-const-block-during-promotion.rs#fail: [missing] -> pass (J0)
  • [ui] tests/ui/inline-const/dont-eval-const-block-during-promotion.rs#pass: [missing] -> pass (J0)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard e96bb7e44fbcc23c1e6009e8d0ee8ab208668fb4 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-apple: 6979.8s -> 9519.1s (+36.4%)
  2. dist-aarch64-linux: 9171.1s -> 6376.7s (-30.5%)
  3. dist-loongarch64-musl: 7538.5s -> 5658.7s (-24.9%)
  4. dist-loongarch64-linux: 7349.9s -> 5641.3s (-23.2%)
  5. dist-apple-various: 3681.0s -> 4322.4s (+17.4%)
  6. dist-x86_64-apple: 7745.2s -> 8831.4s (+14.0%)
  7. dist-aarch64-llvm-mingw: 5237.7s -> 5804.6s (+10.8%)
  8. arm-android: 5325.6s -> 5871.7s (+10.3%)
  9. dist-armv7-linux: 5195.1s -> 5687.0s (+9.5%)
  10. dist-various-2: 2092.2s -> 2281.2s (+9.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e96bb7e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
0.1% [0.0%, 0.1%] 3
Improvements ✅
(primary)
-0.2% [-0.4%, -0.1%] 22
Improvements ✅
(secondary)
-0.5% [-1.9%, -0.1%] 53
All ❌✅ (primary) -0.2% [-0.4%, 0.4%] 23

Max RSS (memory usage)

Results (primary 0.5%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.1% [1.0%, 3.9%] 7
Regressions ❌
(secondary)
5.1% [4.4%, 5.6%] 6
Improvements ✅
(primary)
-2.2% [-4.8%, -0.8%] 4
Improvements ✅
(secondary)
-2.3% [-3.2%, -1.6%] 5
All ❌✅ (primary) 0.5% [-4.8%, 3.9%] 11

Cycles

Results (secondary -1.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.5% [4.3%, 4.7%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.6% [-7.9%, -2.0%] 6
All ❌✅ (primary) - - 0

Binary size

Results (primary 0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.2% [0.1%, 0.5%] 5
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.2% [0.1%, 0.5%] 5

Bootstrap: 473.018s -> 470.891s (-0.45%)
Artifact size: 385.68 MiB -> 383.44 MiB (-0.58%)

@rustbot rustbot added the perf-regression Performance regression. label Jan 27, 2026
@nnethercote
Copy link
Contributor

We have an unexpected perf improvement, yay. Maybe #151694?

@rust-timer build ce5409c

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ce5409c): comparison URL.

Overall result: ❌ regressions - no action needed

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.4% [0.4%, 0.4%] 1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.018s -> 473.507s (0.10%)
Artifact size: 385.68 MiB -> 385.70 MiB (0.00%)

@nnethercote
Copy link
Contributor

@rust-timer build 8d0fe88

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (8d0fe88): comparison URL.

Overall result: no relevant changes - no action needed

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -5.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-5.1% [-5.1%, -5.1%] 1
All ❌✅ (primary) - - 0

Cycles

Results (primary -2.2%, secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
-2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) -2.2% [-2.2%, -2.2%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.018s -> 472.846s (-0.04%)
Artifact size: 385.68 MiB -> 385.70 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. O-hermit Operating System: Hermit O-itron Operating System: ITRON O-SGX Target: SGX O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows perf-regression Performance regression. rollup A PR which is a rollup T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rust-analyzer Relevant to the rust-analyzer team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.