Support v0 demangling of trait object types with assoc const bindings #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The r-l/r PR it would unblock is: rust-lang/rust#150843. However, I'll potentially split out the symbol mangling part into separate PR (at the cost of sliming down a test). This PR is ready. |
BoxyUwU
approved these changes
Jan 15, 2026
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jan 20, 2026
mGCA: Make trait object types with type-level associated consts dyn compatible if all of the latter are specified via bindings Under feature `min_generic_const_args` (mGCA) (#132980), render traits with non-parametrized type-level associated constants (i.e., `#[type_const]` ones) dyn compatible but force the user to specify all type-level associated consts in the trait object type via bindings (either directly, via supertrait bounds and/or behind trait aliases) just like associated types, their sibling. Fixes #130300 (feature request). Fixes #136063 (bug). Fixes #137260 (bug). Fixes #137514 (bug). While I'm accounting for most illegal `Self` references via const projections & params, I'm intentionally ignoring RUST-123140 (and duplicates) in this PR which is to be tackled some other time. Additional context: Crate `rustc-demangle` had to be updated to fix v0 demangling. I've patched it in PR rust-lang/rustc-demangle#87 which was was released in version 0.1.27 via PR rust-lang/rustc-demangle#88.
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jan 21, 2026
mGCA: Make trait object types with type-level associated consts dyn compatible if all of the latter are specified via bindings Under feature `min_generic_const_args` (mGCA) (#132980), render traits with non-parametrized type-level associated constants (i.e., `#[type_const]` ones) dyn compatible but force the user to specify all type-level associated consts in the trait object type via bindings (either directly, via supertrait bounds and/or behind trait aliases) just like associated types, their sibling. Fixes #130300 (feature request). Fixes #136063 (bug). Fixes #137260 (bug). Fixes #137514 (bug). While I'm accounting for most illegal `Self` references via const projections & params, I'm intentionally ignoring RUST-123140 (and duplicates) in this PR which is to be tackled some other time. Additional context: Crate `rustc-demangle` had to be updated to fix v0 demangling. I've patched it in PR rust-lang/rustc-demangle#87 which was was released in version 0.1.27 via PR rust-lang/rustc-demangle#88.
rust-bors bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Jan 22, 2026
mGCA: Make trait object types with type-level associated consts dyn compatible Under feature `min_generic_const_args` (mGCA) (#132980), render traits with non-parametrized type-level associated constants (i.e., `#[type_const]` ones) dyn compatible but force the user to specify all type-level associated consts in the trait object type via bindings (either directly, via supertrait bounds and/or behind trait aliases) just like associated types, their sibling. Fixes #130300 (feature request). Fixes #136063 (bug). Fixes #137260 (bug). Fixes #137514 (bug). While I'm accounting for most illegal `Self` references via const projections & params, I'm intentionally ignoring RUST-123140 (and duplicates) in this PR which is to be tackled some other time. Additional context: Crate `rustc-demangle` had to be updated to fix v0 demangling. I've patched it in PR rust-lang/rustc-demangle#87 which was was released in version 0.1.27 via PR rust-lang/rustc-demangle#88.
This was referenced Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of rust-lang/rust#130300.
I'm blocking this until the relevant r-l/r PR is greenlit.While rustc@main actually mangles assoc const bindings, it does so incorrectly since it doesn't prefix the constant with a
Krendering the output ambiguous I'm pretty sure (prior art: const args get prefixed withKto distinguish them from other kinds of generic args).