Make #if conditions in PSM compliant with CPP #138
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thank you for contributing. This change still needs test coverage. |
Author
|
Sure. @nagisa what are you hoping to test exactly? |
Member
|
Well, if there are conditions under which the build fails, then a test added here would have to be failing before this change and passing after it. This probably can be as simple as somehow forcing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a problem when building with
cargoproper but when we are using rules_rust in bazel, it uses our C toolchain which we use with-Wundefand-Werror, causing a compilation failure. This fixes the issue by using thedefinedpreprocessor statement (https://gcc.gnu.org/onlinedocs/cpp/Defined.html)