Skip to content

Conversation

@bigsaltyfishes
Copy link

Constant and structure extract from <sys/socket.h>, <netlink/netlink.h> and <netlink/netlink_route.h>, some unsupported features are disabled for FreeBSD.

  • set_no_enobufs and set_broadcast_error: System report protocol unsupported, disabled.
  • connect: System report Os { code: 56, kind: Uncategorized, message: "Socket is already connected" , disabled.

@gemini-code-assist
Copy link

Summary of Changes

Hello @bigsaltyfishes, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the library's compatibility to include the FreeBSD operating system. The changes involve carefully isolating platform-specific system calls and data structures, and conditionally disabling features that are not available or behave differently on FreeBSD, ensuring a robust and portable netlink implementation.

Highlights

  • FreeBSD Support: Added initial support for the FreeBSD operating system, expanding the library's compatibility.
  • Platform-Specific Definitions: Introduced a new sys module and ffi/freebsd.rs to define FreeBSD-specific constants and the sockaddr_nl structure, ensuring correct system call interfaces.
  • Conditional Compilation: Implemented conditional compilation (#[cfg(target_os = "freebsd")]) to adapt netlink constants and disable features like connect, set_no_enobufs, and set_broadcast_error on FreeBSD, as they are reported as unsupported.
  • Code Refactoring: Updated SocketAddr and Socket implementations to utilize the new platform-agnostic sockaddr_nl type and constants, improving code maintainability and portability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for FreeBSD by introducing OS-specific constants and types, and by disabling unsupported features on FreeBSD using conditional compilation. The changes are well-structured for cross-platform compatibility. However, I've identified a critical issue in the new sys.rs module that would break compilation on non-FreeBSD platforms. Additionally, there are a couple of high-severity issues in socket.rs where getter functions for unsupported socket options were not disabled for FreeBSD, which would lead to runtime errors. I have provided suggestions to fix these issues.

Constant and structure extract from <sys/socket.h>, <netlink/netlink.h> and <netlink/netlink_route.h>

Signed-off-by: molyuu <bigsaltyfishes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant