web: Fix Enter key being handled as character E #2673
Conversation
When with_prevent_default is set to false, browsers will send keypress events for the enter key, with event.key set to Enter. Ignore it by checking the length of the key string.
|
Minimal test case: https://github.com/johanhelsing/winit/pull/new/with-prevent-default-receive-characters Run the web example and press enter. Observe received character "E" in the log. |
|
@maroider are you happy with this as is, should I rebase to fix the conflicts with the changelog? |
|
@daxpedda, @notgull, @ryanisaacg you are listed as contributors/experts for wasm Do you either of you have the time to review this, and/or know who I could involve to get this PR moving? |
|
There is currently a merge freeze until we are done with #2789, I will review this issue if it's still one afterwards. (I somehow got no notification for this message) |
|
Mentioned patch merged, needs re-evaluation. |
|
This can be closed, with #2662 this isn't an issue anymore, just tested it. |
5 participants
When with_prevent_default is set to false, browsers will send keypress events for the enter key, with event.key set to Enter.
Ignore it by checking the length of the key string.
CHANGELOG.mdif knowledge of this change could be valuable to users[] Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior[ ] Created or updated an example program if it would help users understand this functionality[ ] Updated feature matrix, if new features were added or implemented